Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Bug: Service inventory table doesn't show which sorting is enabled when health status is not available #79827

Closed
formgeist opened this issue Oct 7, 2020 · 1 comment · Fixed by #80447
Closed

[APM] Bug: Service inventory table doesn't show which sorting is enabled when health status is not available #79827

formgeist opened this issue Oct 7, 2020 · 1 comment · Fixed by #80447
Assignees
@smith
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support

Comments

@formgeist
Copy link
Contributor

Kibana version: master

Summary

By default the table is sorted by Transaction per minute, but when health status indicators are available because of ML jobs, we sort by most critical status. We should indicate the default sorting in the default table.

Screenshot 2020-10-07 at 10 55 05
@formgeist formgeist added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support labels Oct 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@smith smith self-assigned this Oct 14, 2020
smith added a commit to smith/kibana that referenced this issue Oct 14, 2020
@smith
Sort service list by TPM if health is not shown
0b86b1d 
Fall back to sorting by transactions per minute if the health column is not available.

Update the test for the component by moving it, removing snapshots, converting to React Testing Library, converting to TypeScript, and adding new cases for this sorting logic.

Fixes elastic#79827.
@smith smith mentioned this issue Oct 14, 2020
Merged
smith added a commit that referenced this issue Oct 15, 2020
@smith
Sort service list by TPM if health is not shown (#80447)
725550f 
Fall back to sorting by transactions per minute if the health column is not available.

Update the test for the component by moving it, removing snapshots, converting to React Testing Library, converting to TypeScript, and adding new cases for this sorting logic.

Fixes #79827.
smith added a commit to smith/kibana that referenced this issue Oct 15, 2020
@smith
Sort service list by TPM if health is not shown (elastic#80447)
09469b3 
Fall back to sorting by transactions per minute if the health column is not available.

Update the test for the component by moving it, removing snapshots, converting to React Testing Library, converting to TypeScript, and adding new cases for this sorting logic.

Fixes elastic#79827.
smith added a commit to smith/kibana that referenced this issue Oct 15, 2020
@smith
Sort service list by TPM if health is not shown (elastic#80447)
2989f01 
Fall back to sorting by transactions per minute if the health column is not available.

Update the test for the component by moving it, removing snapshots, converting to React Testing Library, converting to TypeScript, and adding new cases for this sorting logic.

Fixes elastic#79827.
smith added a commit that referenced this issue Oct 15, 2020
@smith
Sort service list by TPM if health is not shown (#80447) (#80611)
cc30bd8 
Fall back to sorting by transactions per minute if the health column is not available.

Update the test for the component by moving it, removing snapshots, converting to React Testing Library, converting to TypeScript, and adding new cases for this sorting logic.

Fixes #79827.
smith added a commit that referenced this issue Oct 15, 2020
@smith
Sort service list by TPM if health is not shown (#80447) (#80610)
e1074cb 
Fall back to sorting by transactions per minute if the health column is not available.

Update the test for the component by moving it, removing snapshots, converting to React Testing Library, converting to TypeScript, and adding new cases for this sorting logic.

Fixes #79827.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smith smith

Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sort service list by TPM if health is not shown smith/kibana
5 participants
@smith @graphaelli @sorenlouv @formgeist @elasticmachine