Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image embeddable #81345

Closed
Tracked by #71857
streamich opened this issue Oct 21, 2020 · 5 comments · Fixed by #146421
Closed
Tracked by #71857

Image embeddable #81345

streamich opened this issue Oct 21, 2020 · 5 comments · Fixed by #146421
Assignees
@Dosant
Labels
Feature:Dashboard Dashboard related features Feature:Embedding Embedding content via iFrame impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@streamich
Copy link
Contributor

streamich commented Oct 21, 2020 •
edited by exalate-issue-sync bot
Loading

Configuration options:

  • Ability to select image from Files Service.
  • Ability to use external image URL.
    ** For external image use URL allow list service (see URL Drilldown for example)
  • Ability to specify image resizing / presentation options ([~accountid:60996d84391e56006ec93107] to update on that).
  • Ability to set image {{alt}} / tooltip text.
  • Ability to set a link for the image.
    ** External URL allowlist checked.
    ** Maybe new tab checkbox?
    ** Maybe disable checkbox?
  • Ability to hide panel chrome (border, header).
    ** This could be added to the current panel or, maybe better, it could be a new “headless” panel type.
  • Less priority: Panel background color: either default background color (or something simple to implement).
  • Less priority: Ability to select a different image for EUI dark theme mode.
@streamich streamich mentioned this issue Oct 21, 2020
Closed
33 tasks
@streamich streamich added Feature:Embedding Embedding content via iFrame Team:AppArch labels Oct 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 21, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Jul 13, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson
Copy link
Contributor

Adding the presentation team here since we will be building the actual embeddable once the file service is finished

@teresaalvarezsoler
Copy link

Fyi, users will need that images are responsive to different screen sizes so they don't get pixelated or distorted

@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Sep 26, 2022
@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:x-large Extra Large Level of Effort and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:medium Medium Level of Effort labels Oct 20, 2022
@Dosant Dosant self-assigned this Oct 24, 2022
@exalate-issue-sync exalate-issue-sync bot removed the loe:x-large Extra Large Level of Effort label Oct 24, 2022
This was referenced Nov 18, 2022
Merged
Merged
Merged
Dosant added a commit that referenced this issue Nov 24, 2022
@Dosant
[Files] Delay <Image/> blurhash reveal and handle blurhash errors (#…
f6b46ce 
…146159)

## Summary

Follow up to #145347
Needed for #81345
Partially fixes #145567


Two things: 

- [x] Handle errors related to blurhash loading. Make sure that the
original image is loaded if blurhash is failed to generate src or failed
to load
- [x] Make blurhash appear after the delay. This is needed for better UX
when the original image loads fast. Implemented using `css` animation
where first part of the animation is a static state with `opacity: 0,`
and then the image is revealed in the end. If the original image loads
faster, then it appears instantaneously without the delay
@Dosant Dosant mentioned this issue Dec 6, 2022
Merged
15 tasks
@petrklapka petrklapka added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:AppServicesUx labels Dec 12, 2022
Dosant added a commit that referenced this issue Dec 19, 2022
@Dosant
Image Embeddable (#146421)
74ab075 
close #81345

Adds an image embeddable - a new embeddable type that allows to
insert images into dashboard using the new file service
@Dosant Dosant mentioned this issue Dec 23, 2022
Merged
Dosant added a commit that referenced this issue Jan 4, 2023
@Dosant
[Docs][Image Embeddable] Add user-facing docs for image panel (#148054)
72268e1 
## Summary

Adding user-facing docs about new image panel -
#81345

Adding an inline sub-section of the main dashboard doc page similar to
text panel -
https://www.elastic.co/guide/en/kibana/master/dashboard.html#add-text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dosant Dosant

Labels
Feature:Dashboard Dashboard related features Feature:Embedding Embedding content via iFrame impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Image Embeddable Dosant/kibana
7 participants
@Dosant @streamich @ThomThomson @elasticmachine @petrklapka @vadimkibana @teresaalvarezsoler