Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSVB doesn't communicate it's index-patterns to dashboard #81476

Closed
Dosant opened this issue Oct 22, 2020 · 2 comments · Fixed by #82964
Closed

TSVB doesn't communicate it's index-patterns to dashboard #81476

Dosant opened this issue Oct 22, 2020 · 2 comments · Fixed by #82964
Assignees
@alexwizp
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:TSVB TSVB (Time Series Visual Builder) regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas triage_needed

Comments

@Dosant
Copy link
Contributor

Dosant commented Oct 22, 2020

Kibana version: 7.9.3 / master. Works in 7.6.1. Regressed somewhere between 7.6.1 -> 7.9.3

Describe the bug:

For dashboard's filter bar to work visualisations communicate its index-patterns.
Some visualisations don't do that (#19408)
But according to (#19408 (comment)) TSVB should.

This is causing bugs and confusions with how filter bar is working on a dashboard when TSVB is used.
Especially filter bar is almost non usable for dashboards that have only TSVB visualisations and use non-default index patterns.

Steps to reproduce:

  1. Create a TSVB with non default index pattern
  2. Create a dashboard with single TSVB lib
  3. Try to use a filter bar and notice that there is no way to use pick a filter for used index pattern

Expected behavior:

I should be able to create a filter for TSVB's index-pattern.

Any additional context:
@Dosant Dosant added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:TSVB TSVB (Time Series Visual Builder) regression triage_needed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@alexwizp alexwizp self-assigned this Oct 29, 2020
@clintandrewhall clintandrewhall added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@alexwizp alexwizp mentioned this issue Nov 9, 2020
Merged
8 tasks
alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 9, 2020
@alexwizp
TSVB doesn't communicate it's index-patterns to dashboard
e2e02fe 
Closes: elastic#81476
alexwizp added a commit that referenced this issue Nov 16, 2020
@alexwizp @kibanamachine
TSVB doesn't communicate it's index-patterns to dashboard (#82964)
253495b 
* TSVB doesn't communicate it's index-patterns to dashboard

Closes: #81476

* useCustomSearchSource -> getUsedIndexPattern

* fix CI

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 16, 2020
@alexwizp @kibanamachine
TSVB doesn't communicate it's index-patterns to dashboard (elastic#82964
5d85c9a 
)

* TSVB doesn't communicate it's index-patterns to dashboard

Closes: elastic#81476

* useCustomSearchSource -> getUsedIndexPattern

* fix CI

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
alexwizp added a commit that referenced this issue Nov 16, 2020
@alexwizp @kibanamachine
TSVB doesn't communicate it's index-patterns to dashboard (#82964) (#…
9091009 
…83395)

* TSVB doesn't communicate it's index-patterns to dashboard

Closes: #81476

* useCustomSearchSource -> getUsedIndexPattern

* fix CI

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
alexwizp added a commit to alexwizp/kibana that referenced this issue Dec 18, 2020
@alexwizp
TSVB doesn't communicate it's index-patterns to dashboard (elastic#82964
9fa2cc9 
)

* TSVB doesn't communicate it's index-patterns to dashboard

Closes: elastic#81476

* useCustomSearchSource -> getUsedIndexPattern

* fix CI

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/vis_type_timeseries/public/metrics_type.ts
#	src/plugins/visualizations/public/embeddable/create_vis_embeddable_from_object.ts
#	src/plugins/visualizations/public/vis_types/base_vis_type.ts
#	src/plugins/visualizations/public/vis_types/types.ts
alexwizp added a commit that referenced this issue Dec 18, 2020
@alexwizp
[7.10] TSVB doesn't communicate it's index-patterns to dashboard (#82964
1723328 
) (#86448)

* TSVB doesn't communicate it's index-patterns to dashboard (#82964)

* TSVB doesn't communicate it's index-patterns to dashboard

Closes: #81476

* useCustomSearchSource -> getUsedIndexPattern

* fix CI

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/vis_type_timeseries/public/metrics_type.ts
#	src/plugins/visualizations/public/embeddable/create_vis_embeddable_from_object.ts
#	src/plugins/visualizations/public/vis_types/base_vis_type.ts
#	src/plugins/visualizations/public/vis_types/types.ts

* fix CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:TSVB TSVB (Time Series Visual Builder) regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas triage_needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TSVB doesn't communicate it's index-patterns to dashboard alexwizp/kibana
4 participants
@clintandrewhall @Dosant @elasticmachine @alexwizp