Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] [Monitoring] Identify all values used from _source #84370

Closed
5 tasks done
chrisronline opened this issue Nov 25, 2020 · 4 comments
Closed
5 tasks done

[META] [Monitoring] Identify all values used from _source #84370

chrisronline opened this issue Nov 25, 2020 · 4 comments
Labels
Meta Team:Monitoring Stack Monitoring team

Comments

@chrisronline
Copy link
Contributor

chrisronline commented Nov 25, 2020

To help with #73864, we need to help the Beats team identify the fields that need aliasing (which is something we've done already with #73864 (comment)) AND the fields read directly from _source. The effort do to this is great, as we don't have any way to automatically identify these without manually combing through source files.

I think the best way to handle this to convert the files that do read from _source into *.ts files. Then, create a global interface that describes all the fields read with the appropriate types. This will take some time too, but it should also help move us forward with our migration to *.ts

I'm planning to separate this work by stack product

@chrisronline chrisronline added the Team:Monitoring Stack Monitoring team label Nov 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@chrisronline
Copy link
Contributor Author

@igoristic What do you think of this approach? I did one file here: #84375

@sgrodzicki
Copy link

@chrisronline should we close this as all listed PRs are merged?

@chrisronline
Copy link
Contributor Author

We can close it, but I will also use this ticket to communicate the list of fields to @sayden and @ycombinator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meta Team:Monitoring Stack Monitoring team
Projects
None yet
Development

No branches or pull requests

3 participants