Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long Integration name not truncated on Agent details page under the Agent tab. #85404

Closed
ghost opened this issue Dec 9, 2020 · 5 comments · Fixed by #91776
Closed

Long Integration name not truncated on Agent details page under the Agent tab. #85404

ghost opened this issue Dec 9, 2020 · 5 comments · Fixed by #91776
Assignees
@jen-huang
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@ghost
Copy link

ghost commented Dec 9, 2020

Kibana version:
Kibana: 7.11.0-Snapshot cloud environment

Elasticsearch version:
Elasticsearch: 7.11.0-Snapshot

Host OS and Browser version:
Windows 10 , All

Description
Long Integration name not truncated on Agent details page under the Agent tab.

Preconditions

  1. 7.11.0-Snapshot latest Kibana cloud environment should be available with commit 1a6d730
  2. Login into the Kibana environment with 'elastic' superuser.
  3. Agent should be enrolled with default policy having system integration.

Steps

  1. Click on "Fleet" link from L.H.S menu section and navigate to "Fleet" page.
  2. Navigate to 'Policies' tab and select the default policy.
  3. Click on ... link (under Actions column) inline to system integration.
  4. Click on edit integration and provide long name in "Integration name" field.
  5. Click on Save integration.
  6. Go to the Agents tab and click on the agent deployed.
  7. Observed that prerequisite long Integration name not truncated.

Test data
N/A

Impacted Test case id
N/A

Actual Result
Long Integration name not truncated on Agent details page under the Agent tab.

Expected Result
Long Integration name should get truncated on Agent details page under the Agent tab.

What's working
N\A

What's not working
N\A

Screenshot

  • UI break having short agent policy name and long integration name.

Integration_Break

  • UI break having long Agent policy name and long integration name.

Integration_policy_break

Logs

N\A
@ghost ghost added bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team labels Dec 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@ghost ghost added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. v7.11.0 labels Dec 9, 2020
@ghost
Copy link
Author

ghost commented Dec 9, 2020

@manishgupta-qasource : Please review the Bug.

@manishgupta-qasource manishgupta-qasource added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Dec 9, 2020
@manishgupta-qasource
Copy link

Reviewed & Assigned to @EricDavisX

@EricDavisX
Copy link
Contributor

@nchaulet and @hbharding do you have strong feelings on fixing this now or for GA? It doesn't seem urgent to me. Leaving as unassigned for now.

@ph ph removed the v7.11.0 label Jan 11, 2021
@ph
Copy link
Contributor

ph commented Feb 10, 2021

@jen-huang Didn't you fixed that in another PR or something related?

@jen-huang jen-huang self-assigned this Feb 17, 2021
jen-huang added a commit to jen-huang/kibana that referenced this issue Feb 17, 2021
@jen-huang
Truncate long integration names nicely elastic#85404
9adff32
@jen-huang jen-huang mentioned this issue Feb 17, 2021
Merged
jen-huang added a commit that referenced this issue Feb 19, 2021
@jen-huang
[Fleet] Handle long text in agent details page (#91776)
10b1fdd 
* Fix #85521

* Set a minimum height for agent logs component #89831

* Truncate long integration names nicely #85404
jen-huang added a commit to jen-huang/kibana that referenced this issue Feb 19, 2021
@jen-huang
[Fleet] Handle long text in agent details page (elastic#91776)
dd70ce4 
* Fix elastic#85521

* Set a minimum height for agent logs component elastic#89831

* Truncate long integration names nicely elastic#85404
jen-huang added a commit to jen-huang/kibana that referenced this issue Feb 19, 2021
@jen-huang
[Fleet] Handle long text in agent details page (elastic#91776)
583570f 
* Fix elastic#85521

* Set a minimum height for agent logs component elastic#89831

* Truncate long integration names nicely elastic#85404
jen-huang added a commit that referenced this issue Feb 19, 2021
@jen-huang
[Fleet] Handle long text in agent details page (#91776) (#92043)
8b2f281 
* Fix #85521

* Set a minimum height for agent logs component #89831

* Truncate long integration names nicely #85404
jen-huang added a commit that referenced this issue Feb 19, 2021
@jen-huang
[Fleet] Handle long text in agent details page (#91776) (#92042)
d755c1b 
* Fix #85521

* Set a minimum height for agent logs component #89831

* Truncate long integration names nicely #85404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jen-huang jen-huang

Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Handle long text in agent details page jen-huang/kibana
5 participants
@ph @jen-huang @EricDavisX @elasticmachine @manishgupta-qasource