Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Allow users to not render suggestions #85518

Closed
flash1293 opened this issue Dec 10, 2020 · 7 comments · Fixed by #115946
Closed

[Lens] Allow users to not render suggestions #85518

flash1293 opened this issue Dec 10, 2020 · 7 comments · Fixed by #115946
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

Suggestions are relatively expensive because there are one or multiple separate requests dispatched on each state change for each suggestion.

In some environments it's beneficial for the user to turn off these additional queries.

Open questions

  • Is this an advanced setting or something to be done ad-hoc in Lens and saved to local storage?
  • Does this setting turn off suggestions completely or just the dynamic rendering? What do we show in the preview instead?
@flash1293 flash1293 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Dec 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor

My preference is to do this in local storage by adding a new button to "collapse suggestions". Collapsed suggestions would not render or fetch data. This also has some benefits for users on small devices by taking less screen space. I prefer this option over an advanced setting because advanced settings are hard to discover.

@flash1293
Copy link
Contributor Author

This sounds good to me as a first step @wylieconlon

@Karrade7
Copy link

I see this moved to 8.1. Just wanted to mention the lens suggestions become more of a problem in 7.14 with formulas available and more lens options. I'm trying out a formula right now on a data table where I can't get Kibana to return because its waiting for one suggestion (the over time suggestion) The visualization works without a problem on a dashboard, but when I edit the visualization kibana freezes waiting for one suggestion. When I narrowed the time window or reduced the formulas then I was able to edit the visualization.

@dej611
Copy link
Contributor

dej611 commented Aug 23, 2021

@Karrade7 when using formula, as workaround for this type of issues, you could expand the Formula's editor and that would ignore the suggestions - at least during editing.

@Karrade7
Copy link

Karrade7 commented Aug 23, 2021 via email

@ghudgins
Copy link
Contributor

design idea: put a carrot next to "Suggestions" and make the whole thing clickable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants