[event log] Remove event log HTTP APIs if no longer used

[pmuellr]

While reviewing PR #89681, I happened to notice that are URLs are not structured that great.

const BASE_EVENT_LOG_API_PATH = "/api/event_log"

kibana/x-pack/plugins/event_log/server/routes/find.ts

Lines 25 to 27 in b058f78

	router.get(
	{
	path: `${BASE_EVENT_LOG_API_PATH}/{type}/{id}/_find`,

kibana/x-pack/plugins/event_log/server/routes/find_by_ids.ts

Lines 29 to 31 in b058f78

	router.post(
	{
	path: `${BASE_EVENT_LOG_API_PATH}/{type}/_find`,

(new API in PR, shaped the same as others)

kibana/x-pack/plugins/event_log/server/routes/get_events_summary_by_saved_object_ids.ts

Lines 47 to 49 in 53d7f76

	router.post(
	{
	path: `${BASE_EVENT_LOG_API_PATH}/{type}/saved_object_summary`,

Two problems:

• we've now made the path segment after /api/event_log always have to be a type value - since it could be anything, we can't ever create a fixed path like /api/event_log/_do_something, since _do_something could be a SO type
• we may want to have APIs that work over multiple types, but now we can't, since you have to always have a single type as the path segment - I guess you could pass one in on the path, and others via query string, but that's awkward

Seems like we need to reshape these to allow for more URL patterns in the event log in the future.

[elasticmachine]

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

[pmuellr]

Here's the kinda shape I'm thinking about, which would be a little more future-friendly. The uri names are just suggestions, we can probably find better ones.

Method	Current URI	Renamed URI?
GET	{type}/{id}/_find	_find_by_id/{type}/{id}
POST	{type}/_find	_find_by_ids/{type}
POST	{type}/saved_object_summary	_aggs/{type}

[mikecote]

Could also explore removing these APIs if they aren't used.

[pmuellr]

It's not clear we even NEED this API anymore. Does anyone use it???

[EricDavisX]

@dolaru are we using it in the new perf test framework?

[pmuellr]

As near as I can tell, these APIs are not used by Kibana at runtime, but are used by function tests. So, seems like we should move them INTO the function tests, so we can verify we're not using them, so we don't have to really worry about them anymore. Perhaps when we move them, we can see if we can just convert the uses into direct ES calls, and remove the routes entirely.

Also, since the issue was created, the endpoints have moved to /internal/event_log, so I don't think we have any "breaking" API here.

Not seeing any urgency to get this done, so seems deferrable, but also seems fairly simple.

[pmuellr]

Mike pointed out that the Kibana load testing tools we use may be using these APIs as well. We should find out, and then see if those routes (if used) can be replaced with searches directly against the event log indices.

[mikecote]

I changed the title to [event log] Remove event log HTTP APIs if no longer used. Let's remove them if they aren't used. It feels like they aren't after searching for usage myself.