Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TS to v4.2 #90788

Closed
mshustov opened this issue Feb 9, 2021 · 4 comments
Closed

Update TS to v4.2 #90788

mshustov opened this issue Feb 9, 2021 · 4 comments
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team

Comments

@mshustov
Copy link
Contributor

mshustov commented Feb 9, 2021 •
edited
Loading

During the migration to TS projects we found several problems that should be fixed in the upcoming v4.2 release:
microsoft/TypeScript#37888
microsoft/TypeScript#40718

Release notes: https://devblogs.microsoft.com/typescript/announcing-typescript-4-2-beta/

WIP: https://github.com/restrry/kibana/tree/ts-4-2-rc
@smith smith mentioned this issue Feb 9, 2021
Merged
@nickpeihl nickpeihl added the Team:Operations Team label for Operations Team label Feb 12, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mshustov mshustov added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Apr 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@Bamieh
Copy link
Member

Bamieh commented Apr 21, 2021

Just a heads up. The following change might impact the telemetry tooling:

TypeScript’s lift Callback in visitNode Uses a Different Type

TypeScript has a visitNode function that takes a lift function. lift now expects a readonly Node[] instead of a NodeArray<Node>. This is technically an API breaking change which you can read more on here.

We have unit tests for the package so the tests should fail if something goes wrong during the upgrade.

@jbudz
Copy link
Member

jbudz commented Aug 26, 2021

Superseded by #100563

@jbudz jbudz closed this as completed Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nickpeihl @jbudz @mshustov @Bamieh @elasticmachine