TypeScript project references for APM

[smith]

There are a few workarounds for a bug in TypeScript 4.2, which can be removed once we've upgraded to that (we're tracking this in #90788.)

Because we're emitting declarations a few extra interfaces need to be exported.

The optimization scripts have been removed.

The scripts directory previously had its own tsconfig, but now everything is under one config, so a few changes were made there.

Change all spelling of "throuput" to "throughput"

Fixes #81003. References #80508.

[kibanamachine]

⏳ Build in-progress, with failures

• continuous-integration/kibana-ci/pull-request
• Commit: 0184fdb
• This comment will update when the build is complete

Failed CI Steps

• Setup Build Environment and Dependencies
• Setup Build Environment and Dependencies
• Setup Build Environment and Dependencies
• Setup Build Environment and Dependencies

History

• 💔 Build #103094 failed a62afc4
• 💔 Build #103086 failed 52e8bab

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[smith]

retest

[smith]

@elasticmachine merge upstream

[dgieselaar]

I had a look, and completionInfo() is still twice as fast with the optimized tsconfig, and project start up time also seems to be slower. I'm not sure if I'm doing something wrong. What do you think about leaving this in for now and removing it later if we feel like it's no longer worth it?

[smith]

I think we would be better served by concentrating any effort on further performance kibana-wide, rather than having a different setup for APM. I'm ok with leaving it in, but don't think we should.

[dgieselaar]

I agree in not spending any effort to improve this. So if it's causing issues let's remove it. But it worked well before, and I would like us to keep it around for a bit longer to compare the two different setups.

[smith]

@elasticmachine merge upstream

[sorenlouv]

Is it not possible to use the variables anymore?

[dgieselaar]

It's a bug in 4.1 that will be fixed in 4.2. There's some explanation in the comment above this code.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 29ce741

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
apm	5.2MB	5.2MB	+22.0B

History

• 💛 Build #105891 was flaky 0370e67
• 💔 Build #105768 failed 7fefbc6
• 💚 Build #105595 succeeded 687cd67
• 💔 Build #105490 failed ae795a4
• 💔 Build #105464 failed d995a99

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[dgieselaar]

Thanks Nathan!

[kibanamachine]

Backport result

{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"meta":{"labels":["Team:apm","Team:uptime","auto-backport","release_note:skip","v7.12.0","v8.0.0"],"branchLabelMapping":{"^v8.0.0$":"master","^v7.12.0$":"7.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"},"existingTargetPullRequests":[]},"level":"info","message":"Inputs when calculating target branches:"}
{"meta":["7.x"],"level":"info","message":"Target branches inferred from labels:"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm kibanamachine","stdout":"","stderr":"error: No such remote: 'kibanamachine'\n"},"level":"info","message":"exec error 'git remote rm kibanamachine':"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm elastic","stdout":"","stderr":"error: No such remote: 'elastic'\n"},"level":"info","message":"exec error 'git remote rm elastic':"}
{"level":"info","message":"Backporting [{\"sourceBranch\":\"master\",\"targetBranchesFromLabels\":[\"7.x\"],\"sha\":\"f9804057c85a0357698fa8ef708d14cdbd6342f0\",\"formattedMessage\":\"TypeScript project references for APM (#90049)\",\"originalMessage\":\"TypeScript project references for APM (#90049)\\n\\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\\r\\nCo-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>\",\"pullNumber\":90049,\"existingTargetPullRequests\":[]}] to 7.x"}

Backporting to 7.x:
{"level":"info","message":"Backporting via filesystem"}
{"meta":{"killed":false,"code":1,"signal":null,"cmd":"git cherry-pick f9804057c85a0357698fa8ef708d14cdbd6342f0","stdout":"Auto-merging x-pack/plugins/apm/server/lib/transaction_groups/fetcher.ts\nAuto-merging x-pack/plugins/apm/server/lib/traces/get_trace_items.ts\nAuto-merging x-pack/plugins/apm/server/lib/services/get_service_metadata_icons.ts\nAuto-merging x-pack/plugins/apm/server/lib/services/get_service_metadata_details.ts\nAuto-merging x-pack/plugins/apm/server/lib/index_pattern/get_dynamic_index_pattern.ts\nAuto-merging x-pack/plugins/apm/server/lib/helpers/create_es_client/create_apm_event_client/index.ts\nCONFLICT (content): Merge conflict in x-pack/plugins/apm/server/lib/helpers/create_es_client/create_apm_event_client/index.ts\nRemoving x-pack/plugins/apm/scripts/tsconfig.json\n","stderr":"error: could not apply f9804057c85... TypeScript project references for APM (#90049)\nhint: after resolving the conflicts, mark the corrected paths\nhint: with 'git add <paths>' or 'git rm <paths>'\nhint: and commit the result with 'git commit'\n"},"level":"info","message":"exec error 'git cherry-pick f9804057c85a0357698fa8ef708d14cdbd6342f0':"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git --no-pager diff --check","stdout":"x-pack/plugins/apm/server/lib/helpers/create_es_client/create_apm_event_client/index.ts:42: leftover conflict marker\nx-pack/plugins/apm/server/lib/helpers/create_es_client/create_apm_event_client/index.ts:49: leftover conflict marker\nx-pack/plugins/apm/server/lib/helpers/create_es_client/create_apm_event_client/index.ts:54: leftover conflict marker\n","stderr":""},"level":"info","message":"exec error 'git --no-pager diff --check':"}
Commit could not be cherrypicked due to conflicts