Remove circular dependency between fleet and security_solution #91111
Assignees
Labels
Feature:Fleet
Fleet team's agent central management project
Team:Fleet
Team label for Observability Data Collection Fleet team
v7.13.0
Comments
mshustov
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
This was referenced Feb 11, 2021
Merged
@restrry @ph can this go in 7.13? Or should it go in 7.12 (Feature Freeze in ~2 working day)? |
|
the beginning of 7.13 is fine 👍 |
|
Added to 7.13. roadmap. @jfsiii I presume you would be looking into that? |
|
@ph sure, I am happy to. I'm confused about losing the 7.13 tag/meta though. |
1 task
jfsiii
pushed a commit
that referenced
this issue
Mar 11, 2021
## Problem There's a circular dependency #91111 between the `fleet` and `security_solution` plugins * `security_solution` depends on `fleet`, but * `fleet` has (_had_ with this PR) an `import` from `security_solution` (migrations for the 7.11 and 7.12 package policy objects) ## Proposed solution ### (A) This PR Move the two imported functions from `security` into `fleet`. ### (B) Follow up issue Putting integration-specific code into `fleet` doesn't scale (technically or cognitively). Discuss if this use case (specifying saved object migrations, etc) applies to other plugins. e.g. can `apm` do this? `nginx`? If so, should we find a way to move this out of `fleet`? ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios closes #91111 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Mar 11, 2021
…4171) ## Problem There's a circular dependency elastic#91111 between the `fleet` and `security_solution` plugins * `security_solution` depends on `fleet`, but * `fleet` has (_had_ with this PR) an `import` from `security_solution` (migrations for the 7.11 and 7.12 package policy objects) ## Proposed solution ### (A) This PR Move the two imported functions from `security` into `fleet`. ### (B) Follow up issue Putting integration-specific code into `fleet` doesn't scale (technically or cognitively). Discuss if this use case (specifying saved object migrations, etc) applies to other plugins. e.g. can `apm` do this? `nginx`? If so, should we find a way to move this out of `fleet`? ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios closes elastic#91111 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this issue
Mar 11, 2021
…94483) ## Problem There's a circular dependency #91111 between the `fleet` and `security_solution` plugins * `security_solution` depends on `fleet`, but * `fleet` has (_had_ with this PR) an `import` from `security_solution` (migrations for the 7.11 and 7.12 package policy objects) ## Proposed solution ### (A) This PR Move the two imported functions from `security` into `fleet`. ### (B) Follow up issue Putting integration-specific code into `fleet` doesn't scale (technically or cognitively). Discuss if this use case (specifying saved object migrations, etc) applies to other plugins. e.g. can `apm` do this? `nginx`? If so, should we find a way to move this out of `fleet`? ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios closes #91111 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: John Schulz <john.schulz@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I added a workaround to make TS compiler work, but it should be solved properly.
The added workaround doesn't provide type safety and blocks migration to Bazel build chain.
https://github.com/elastic/kibana/pull/90492/files#diff-884e5b0856b6d3f34cafda4f746a3759fd00953fb11042dcd6116ef0c32e9abb
cc @jfsiii
The text was updated successfully, but these errors were encountered: