-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Kibana Apps gracefully handle index pattern field changes and removal #92753
Comments
For alerting, we'll be looking at the "stack" alerts that the alerting team provides, but other teams also provide solution-specific alerts, so I think they need to "own" this issue for their alerts. Specifically, I guess our thinking is that these alerts could run into issues potentially if runtime fields are being accessed by the alerts. Eg, what happens if I create an index threshold alert, which checks a field agg vs a threshold value, that field is a runtime field that exists when the alert is created, but is later changed/deleted. I don't believe there is any alerting framework enhancement we would provide to handle this ATM, presumably every alert type is responsible for handling errors their queries are making using the existing alerting framework facilities. So this ends up pulling in the following areas. As an additional thing for existing "owners" listed above to look at:
And then these areas current listed as "not applicable" - they are now applicable :-)
|
@pmuellr Thanks! Updated the description to reflect your advice. |
Pinging @elastic/kibana-app-services (Team:AppServices) |
Alerting investigation complete. Focused on how the UI and stack rule execution was affected by field mapping changes/deletions due to runtime fields. Created these issues as a result of the investigation:
|
wrt Maps-app: cf #93481 tl;dr:
|
Mappings and field lists change and we need to make sure that Kibana handles this gracefully. Field lists are expected to change more frequently with the introduction of runtime fields. Runtime fields may be removed or their types may change, either of which may be disruptive to code that assumes their presence is unchanged.
We should ensure that when a field changes or is missing that the UI remains in a workable state and that the user has a path to completing their task. This is purposefully vague because of the diversity of kibana apps. It intends to be a low bar, "good enough". We do not need to design experiences around this circumstance for the purposes of this issue.
Please note how affected UIs handle changes to runtime fields.
UPDATE: We also need to verify alerting use cases
Kibana App
Owner: @timroes
Investigation: Complete
Lens: Before a visualization renders, field type and existence is checked and an explanatory error message is shown for fields used in aggregations. In the editor the user can fix the visualization (or the runtime field) to make it work again. This is only visible once a user accesses the visualization (either on a dashboard or in the Lens editor), not in the visualization listing. No special check for usage in KQL filters (Elasticsearch simply won't return any data, no error indication)
Rest visualizations: #93921
App Arch
Owner: @mattkime
Investigation: Complete
Notes: CSV reports will have a blank column if a field is missing. Filter bar - If a filter exist that references a removed field, the filter remains functional and can be removed by the user.
Alerting #93501
Owner: @mikecote
Investigation: Not started
Notes
Maps
Owner: @thomasneirynck
Investigation: see #93481
Alerts investigation: Not started
Logs & Metrics
Owner: @weltenwort
Investigation: Not yet started
Alerts investigation: Not started
Notes In process of adopting index patterns
ML #93571
Owner: @peteharverson
Investigation: Complete - see #93571
Alerts investigation: Complete - see #93571
Notes In general ML jobs and Transforms copy over the definitions of the runtime fields to the
runtime_mappings
of the job / transform config, and will continue to use the definition stored in the job / transform, rather than the one stored in the index pattern.APM (#94288)
Owner: @sqren
Alerts investigation: Complete
Notes
Stack Monitoring
Owner: @chrisronline
Alerts investigation: done
Notes No index pattern usage
Not Applicable
Telemetry
Core UI
Ingest
Elasticsearch UI
Enterprise search
The text was updated successfully, but these errors were encountered: