Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visualize] Support runtime fields editor #93921

Closed
stratoula opened this issue Mar 8, 2021 · 2 comments · Fixed by #94798
Closed

[Visualize] Support runtime fields editor #93921

stratoula opened this issue Mar 8, 2021 · 2 comments · Fixed by #94798
Labels
Feature:Vis Editor Visualization editor issues Meta Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

stratoula commented Mar 8, 2021

I have gathered here the way that Visualize works currently with the runtime fields editor.

  1. Vega and Timelion are not going to support them so no problem here.

  2. Right now, TSVB doesn't support them, we should track this here

  3. Create a viz with a runtime field and them remove the field

  • The listing page works as expected
  • When I click on the broken visualization it navigates me to the edit saved object page:
    image
  • On a dashboard (I can't edit the broken visualization):
    image
  1. Create a viz with a runtime field and then change the type
    I can see two cases here:
    If the new type is supported by the aggregation set, then the visualization works as expected (for example change from double to long)
    If it is not supported and try to open it from the listing I get the following error (it redirects again on the listing page, visualization doesn't load):
    image
    On a dashboard (I can't edit the broken visualization):
    image

  2. Create a runtime field without a value
    I can see the field on the fields dropdowns, the visualization is rendered with No results found message
    image

  3. Change the format, it works and is depicted on the chart

  4. Popularity doesn't work, fields are loaded alphabetically - Update: My mistake here, this setting is only for Discover. No extra action here.

  5. Creating a viz from a Discover search with a runtime field, and then delete the field.

  • If the visualization is not based on a runtime field it will be rendered with no data, it is not broken
    image

  • If the visualization is based on a runtime field then it fails (see 3)

How are we going to handle them?

Broken visualizations should load with an error, allowing the users to fix them

@stratoula stratoula added discuss Meta Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula stratoula added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Feature:Vis Editor Visualization editor issues and removed Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Mar 8, 2021
@stratoula
Copy link
Contributor Author

stratoula commented Mar 8, 2021

I have created separate issues for the above:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Vis Editor Visualization editor issues Meta Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants