-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EUI][Data] - Add index field selectors to EUI or Data #94875
Comments
Pinging @elastic/eui-design (EUI) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/kibana-core (Team:Core) |
Why EUI and not simply an utility component? |
I will agree, that the rounded badge seems very particular to this component in the way that it's displayed along with the connecting dots. I would be worried about making this a very specific EUI component. But I do agree that all these places could probably benefit from the same UI. I would recommend starting with a shared component/utility in Kibana and work to replace those places mentioned with this new component to see how well it works before we consider pulling it up to EUI. Does that seem like an ok approach? |
Describe the feature:
Currently the security solutions team is working to move exception list UI into the
lists
plugin. In doing so, it's clear that a number of areas use similar components and that similar components exist within other plugins likedata
. I'll try to dig into the shared functionality and areas where it's being used as best I can to demonstrate that a streamlined component could be useful.With the RAC initiative (unified alerting experience), these components will start being used in other plugins like observability.
Describe a specific use case for the feature:
Below are some of the areas in which this component shows up.
data
plugin has had a version for a while. When we were building out exceptions we chose not to use theirs because we weren't able to customize which operators could be used and it didn't have support for nested fields (at least not displayed the way we wanted).Common functionality
some field is some value
data
possibly?AND
-ed orOR
-ed in some cases it's logic that is abstracted. Adding filters for example, it has you do one at a time as opposed to allowing the user to explicitlyAND
itExceptions
lists
pluginExample of exceptions with nested
Indicator Match Rule
Trusted Apps
Adding a Filter
Severity Override
The text was updated successfully, but these errors were encountered: