[Security Solution][Exceptions] - Moves ExceptionItem component to lists plugin

[yctercero]

Summary

Moves part of the exceptions UI out of the security solution plugin and into the lists plugin. In order to keep PRs (relatively) small, I am moving single components at a time. This should also then help more easily pinpoint the source of any issues that come up along the way.

The next couple PRs will focus on the exception builder. This one in particular is focused on moving over the BuilderExceptionItem which deals with rendering the individual exception items.

Quick Summary:

• x-pack/plugins/security_solution/public/common/components/exceptions/builder/exception_item.tsx → x-pack/plugins/lists/public/exceptions/components/builder/exception_item_renderer.tsx
  • Corresponding unit test file moved as well
  • Updated security solution exception builder to pull BuilderExceptionItem from lists plugin
• Copied x-pack/plugins/security_solution/public/common/components/and_or_badge/ to x-pack/plugins/lists/public/exceptions/components/and_or_badge/
  • As these components are also used in non exceptions flows in security solution, did not remove there
  • Working on creating an issue to see if these components can be taken up by EUI (reached out to the team and they suggested this as a first step) [EUI][Data] - Add index field selectors to EUI or Data #94875

Entry Item (PR)

Exception Item (THIS PR DEALS WITH 👇🏽)

Builder Buttons

Exception Item Comments

Builder Modal

Notes

• There may still be work to do to get the component working for all use cases, however, for the moment being, concentrating on moving existing functionality over

Testing

Prior to making these changes, added a number of tests to ensure coverage of existing functionality. For manual testing, please checkout PR and play around with the following:

• Add/edit an exception item
  • if an existing item, make sure that it populates as expected in the modal
• Add/edit different entry types like match, match_any, nested etc.
• Play around with the component in storybook

Checklist

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

[elasticmachine]

Pinging @elastic/security-solution (Team: SecuritySolution)

[elasticmachine]

Pinging @elastic/security-detections-response (Team:Detections and Resp)

[dplumlee]

Already left a review on the builder pr but this also looks good on all the manual testing i did with it 👍

[yctercero]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 1ffb2f7
• Storybooks Preview

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
lists	149	156	+7
securitySolution	2209	2206	-3
total			+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
securitySolution	7.2MB	7.2MB	-9.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
lists	176.6KB	190.2KB	+13.6KB

History

• 💔 Build #115627 failed ab65ff3
• 💔 Build #115616 failed 4145788
• 💚 Build #115405 succeeded b62f213
• 💚 Build #114775 succeeded 45597a9
• 💔 Build #114754 failed 213ef13

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero