Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Data Table - Text Alignment not applied to column headers #98644

Closed
dsadosky opened this issue Apr 28, 2021 · 6 comments · Fixed by #101875
Closed

[Lens] Data Table - Text Alignment not applied to column headers #98644

dsadosky opened this issue Apr 28, 2021 · 6 comments · Fixed by #101875
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@dsadosky
Copy link

Kibana version: 7.12

Elasticsearch version: 7.12

Server OS version:. ESS

Browser version:

Browser OS version:

Original install method (e.g. download page, yum, from source, etc.):

Describe the bug:
When creating a data table using Lens, each column allows for the text alignment to be left, center, or right. This alignment works fine for the data but the same alignment SHOULD be applied to the column headers. Today the column headers are always left aligned making it hard to read when the data is right or center aligned.

Steps to reproduce:

  1. Create a table table in Lens
  2. For each column choose Text Alignment Left, Right, or Center
  3. Notice the data is aligned accordingly but the column headers are not aligned to the data

Expected behavior:
Column headers should assume the same alignment pattern as the data in the table.

Screenshots (if relevant):

image

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

@dsadosky dsadosky added the bug Fixes for quality problems that affect the customer experience label Apr 28, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 28, 2021
@azasypkin azasypkin added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Apr 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 29, 2021
@flash1293
Copy link
Contributor

Not sure whether this qualifies as a bug or as an enhancement - cc @MichaelMarcialis from your side, do you think we should align the headers like the data cells by default? Or should it be a setting?

@MichaelMarcialis
Copy link
Contributor

@flash1293: Yes, table headers should have the same alignment as their related table cells. I believe this is a known issue with EuiDataGrid, but I was unable to find an open issue on it in their repo. @chandlerprall, is this alignment issue for datagrid being actively tracked? Or should I make an issue for it?

@flash1293
Copy link
Contributor

If it's an EUI limitation I'll move this to blocked bugs for now

@chandlerprall
Copy link
Contributor

@MichaelMarcialis I don't think we have an existing for that

@dej611
Copy link
Contributor

dej611 commented Jun 16, 2021

@chandlerprall the issue has been just addressed on the Lens/consumer side using the EuiDataGridColumn['display'] prop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants