Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Add draw wizard #100278

Merged
merged 85 commits into from
May 26, 2021
Merged

[Maps] Add draw wizard #100278

merged 85 commits into from
May 26, 2021

Conversation

thomasneirynck
Copy link
Contributor

Replaces #96913

Aaron Caldwell added 30 commits March 26, 2021 15:50
Placeholder feature edit control in place
5f8aa18
Merge remote-tracking branch 'upstream/master' into shape-drawing-ui
2cbd6b0
Placeholder menu added
a80038a
Redux integrated
26ec7bf
Single shape drawing
8ca809a
Merge remote-tracking branch 'upstream/master' into shape-drawing-ui
f9eeb95
Keep draw mode active
b8eea96
Trigger editing through add layer wizard
b4f3af0
Add index checking utils
001c87f
Connect error checking
95f8f14
Conditionally show edit toolbar
2de30ec
Connect missing shapes. Some clean up
92e17aa
Track features and index name in store
143b24a
Connect add layer button enablement
e129539
Connect persistence utils
9c5ca16
Dispatch clearing action
423e3aa
Full roundtrip w/ settings showing. Moved async calls to component
f238ccb
Adjust addLayer call for async
d450fd1
Merge remote-tracking branch 'upstream/master' into shape-drawing-ui
3d7ad76
Add edit controls
b12ad85
Fix deleting functionality to update store
576b3d3
Add toggle color to buttons. Fall back to edit between drawings
cd211f9
Deselect features still selected when entering trash mode
4f79738
Add geometry check to filter out invalid geometries
ceae6d2
Clear out old drawing data on cancel. Update action names
bee0fd5
Add circle drawing button
3725859
Add tools show on map with cancel. Not completely connected to add la…
5200165 
…yer code
Merge remote-tracking branch 'upstream/master' into shape-drawing-wizard
2cb1832
Controls and feature handling almost entirely removed. Index creation…
4ab4c54 
… step not initiating
Remove more unused files related to draw toolbar
32e4dcf
@thomasneirynck thomasneirynck requested a review from kindsun May 18, 2021 18:25
nreese
nreese reviewed May 19, 2021
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some work when displaying index creation error in new_vector_layer_wizard/wizard.

x-pack/plugins/file_upload/public/api/json_upload_and_parse_async_wrapper.tsx Show resolved Hide resolved
x-pack/plugins/file_upload/public/components/geojson_upload_form/index_name_form.tsx Outdated Show resolved Hide resolved
x-pack/plugins/file_upload/public/components/geojson_upload_form/index_name_form.tsx Outdated Show resolved Hide resolved
x-pack/plugins/maps/public/classes/layers/new_vector_layer_wizard/utils/indexing_service.ts Outdated Show resolved Hide resolved
x-pack/plugins/maps/public/classes/layers/new_vector_layer_wizard/utils/indexing_service.ts Outdated Show resolved Hide resolved
x-pack/plugins/maps/public/classes/layers/new_vector_layer_wizard/wizard.tsx Outdated Show resolved Hide resolved
x-pack/plugins/maps/public/classes/layers/new_vector_layer_wizard/wizard.tsx Outdated Show resolved Hide resolved
x-pack/plugins/maps/public/classes/layers/new_vector_layer_wizard/wizard.tsx Outdated Show resolved Hide resolved
x-pack/plugins/maps/public/classes/layers/new_vector_layer_wizard/wizard.tsx Outdated Show resolved Hide resolved
x-pack/plugins/maps/public/classes/layers/new_vector_layer_wizard/wizard.tsx Show resolved Hide resolved
@thomasneirynck thomasneirynck marked this pull request as ready for review May 25, 2021 19:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck thomasneirynck requested a review from nreese May 25, 2021 19:10
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fileUpload 159 161 +2
maps 780 785 +5
total +7

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
maps 191 193 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.7MB 2.7MB +6.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fileUpload 21.5KB 23.2KB +1.8KB
maps 62.1KB 62.5KB +363.0B
total +2.1KB
Unknown metric groups

API count

id before after diff
maps 192 194 +2

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 386 342 -44
stackAlerts 101 95 -6
total -342

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nreese
nreese approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasneirynck thomasneirynck added auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes and removed release_note:enhancement labels May 26, 2021
@thomasneirynck
Copy link
Contributor Author

skipping from release-notes, because still behind feature-flag.

@thomasneirynck thomasneirynck merged commit c5aa398 into elastic:master May 26, 2021
@kibanamachine kibanamachine mentioned this pull request May 26, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 26, 2021
@thomasneirynck @kibanamachine
[Maps] Add draw wizard (elastic#100278)
df0c83f
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

gmmorris added a commit to gmmorris/kibana that referenced this pull request May 26, 2021
@gmmorris
Merge branch 'master' into task-manager/capacity-estimation
4417858 
* master: (60 commits)
  [Docs] Index patterns REST API docs (elastic#100549)
  [Ingest pipelines] add support for fingerprint processor (elastic#100541)
  ping Core team when renovate bot bumps es client version (elastic#100662)
  [Maps] Add draw wizard (elastic#100278)
  Use documentation link service for index pattern field editor (elastic#100609)
  [Maps] filter dashboard by map extent (elastic#99860)
  [ftr] migrate screenshots and snapshots services to FtrService class (elastic#100514)
  fix anomaly functional test (elastic#100504)
  update breaking changes template to incorporate ES deprecations (elastic#100621)
  improve default time ranges (elastic#100536)
  [Gauge] Fixes wrong translations on ranges less than symbol (elastic#100535)
  [ftr] migrate "globalNav" service to FtrService class (elastic#100604)
  [ftr] migrate "testSubjects" to FtrService class (elastic#100512)
  Fix spaces test flakyness (elastic#100605)
  [Ingest pipelines] add support for ip type in convert processor (elastic#100531)
  [ftr] migrate "browser" to FtrService class (elastic#100507)
  [ftr] migrate "find" service to FtrService class (elastic#100509)
  [telemetry] report config deprecations (elastic#99887)
  [ftr] migrate "docTable" service to FtrService class (elastic#100595)
  [ftr] migrate "listingTable" service to FtrService class (elastic#100606)
  ...
kibanamachine added a commit that referenced this pull request May 26, 2021
@kibanamachine @thomasneirynck
[Maps] Add draw wizard (#100278) (#100695)
08864b2 
Co-authored-by: Thomas Neirynck <thomas@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@kindsun kindsun Awaiting requested review from kindsun

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thomasneirynck @elasticmachine @kibanamachine @nreese @elizabetdev @kindsun