Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Reduces the lists limits to the current max + 15kb #100419

Merged
merged 1 commit into from
May 20, 2021
Merged

[Security Solution] Reduces the lists limits to the current max + 15kb #100419

merged 1 commit into from
May 20, 2021

Conversation

FrankHassanabad
Copy link
Contributor

@FrankHassanabad FrankHassanabad commented May 20, 2021 •
edited by tylersmalley
Loading

Summary

Reduces the lists limits to the current max + 15kb

Closes #95867

@FrankHassanabad FrankHassanabad requested a review from a team as a code owner May 20, 2021 18:49
@FrankHassanabad FrankHassanabad self-assigned this May 20, 2021
@FrankHassanabad FrankHassanabad added v8.0.0 v7.14.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed labels May 20, 2021
@FrankHassanabad FrankHassanabad enabled auto-merge (squash) May 20, 2021 18:50
tylersmalley
tylersmalley approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@tylersmalley tylersmalley left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
stackAlerts 101 95 -6
total -295

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @FrankHassanabad

@FrankHassanabad FrankHassanabad merged commit d7234e0 into elastic:master May 20, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 20, 2021
@FrankHassanabad @kibanamachine
Reduce the lists limits to the current max + 15kb (elastic#100419)
8372875 
## Summary

Reduces the lists limits to the current max + 15kb
@kibanamachine kibanamachine mentioned this pull request May 20, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 20, 2021
@kibanamachine @FrankHassanabad
Reduce the lists limits to the current max + 15kb (#100419) (#100421)
0d0d0df 
## Summary

Reduces the lists limits to the current max + 15kb

Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
yctercero pushed a commit to yctercero/kibana that referenced this pull request May 25, 2021
@FrankHassanabad @yctercero
Reduce the lists limits to the current max + 15kb (elastic#100419)
57bab18 
## Summary

Reduces the lists limits to the current max + 15kb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@tylersmalley tylersmalley tylersmalley approved these changes

Assignees

@FrankHassanabad FrankHassanabad

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[lists] Reduce page load bundle to under 100kB
4 participants
@FrankHassanabad @kibanamachine @tylersmalley @jbudz