Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ftr] migrate "flyout" and "inspector" services to FtrService class #100602

Merged
merged 9 commits into from
May 26, 2021
Merged

[ftr] migrate "flyout" and "inspector" services to FtrService class #100602

merged 9 commits into from
May 26, 2021

Conversation

spalger
Copy link
Contributor

@spalger spalger commented May 25, 2021

In order to migrate the root test directory to its own TypeScript project that can be ref'd we need to stop returning class expressions from provider functions. Part of #99148

Migrates the "flyout" and "inspector" services to the new FtrService class, basically just extracted the classes from the providers and remapped services/PageObjects referenced in scope to access private properties on the service instance. Viewing changes with whitespace disabled will help with review.

@spalger spalger added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed Team:QA Team label for QA Team labels May 25, 2021
@spalger spalger marked this pull request as ready for review May 25, 2021 21:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@spalger spalger requested a review from dmlemeshko May 25, 2021 21:10
@spalger spalger enabled auto-merge (squash) May 25, 2021 21:11
@dmlemeshko
Copy link
Member

Checking ^ failure locally

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 386 342 -44
stackAlerts 101 95 -6
total -342

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit af59f68 into elastic:master May 26, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 26, 2021
@spalger @kibanamachine
[ftr] migrate "flyout" and "inspector" services to FtrService class (e…
7df656c 
…lastic#100602)

Co-authored-by: spalger <spalger@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request May 26, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@spalger spalger deleted the migrate/ftr-service-class/flyout-inspector branch May 26, 2021 21:12
kibanamachine added a commit that referenced this pull request May 26, 2021
@kibanamachine @spalger
[ftr] migrate "flyout" and "inspector" services to FtrService class (#…
b6a2316 
…100602) (#100739)

Co-authored-by: spalger <spalger@users.noreply.github.com>

Co-authored-by: Spencer <email@spalger.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlemeshko dmlemeshko dmlemeshko approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spalger @elasticmachine @dmlemeshko @kibanamachine