-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas] Update slow query in sample ecommerce workpad #100714
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poffdeluxe
added
review
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
loe:small
Small Level of Effort
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
Feature:Canvas
v7.14.0
v7.13.1
labels
May 26, 2021
Pinging @elastic/kibana-presentation (Team:Presentation) |
@elasticmachine merge upstream |
poffdeluxe
added
v7.13.2
auto-backport
Deprecated - use backport:version if exact versions are needed
and removed
v7.13.1
labels
Jun 9, 2021
@elasticmachine merge upstream |
clintandrewhall
approved these changes
Jun 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/discover/_sidebar·ts.discover app discover sidebar field filtering should reveal and hide the filter form when the toggle is clickedStandard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 9, 2021
* Update slow query in sample ecommerce workpad * Remove demodata use from sample ecomm workpad Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 9, 2021
* Update slow query in sample ecommerce workpad * Remove demodata use from sample ecomm workpad Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Jun 9, 2021
…1805) * Update slow query in sample ecommerce workpad * Remove demodata use from sample ecomm workpad Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Poff Poffenberger <poffdeluxe@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Jun 9, 2021
…1806) * Update slow query in sample ecommerce workpad * Remove demodata use from sample ecomm workpad Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Poff Poffenberger <poffdeluxe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
Feature:Canvas
impact:medium
Addressing this issue will have a medium level of impact on the quality/strength of our product.
loe:small
Small Level of Effort
release_note:skip
Skip the PR/issue when compiling release notes
review
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
v7.13.2
v7.14.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changing some expressions from
esdocs
query that pulls all the records and then does counting toessql
query that does the counting in the query.This gets rid of the weird hanging that would happen in some cases when viewing this workpad. This workpad loads pretty quickly now!