Fix alerting health API to consider rules in all spaces #100879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
release_note:fix
Feature:Alerting
v8.0.0
Team:ResponseOps
mikecote
commented
May 28, 2021
Comment on lines
+82
to
+84
| expect(health.alerting_framework_heath.decryption_health.status).to.eql('ok'); | ||
| expect(health.alerting_framework_heath.execution_health.status).to.eql('ok'); | ||
| expect(health.alerting_framework_heath.read_health.status).to.eql('ok'); |
There was a problem hiding this comment.
There is potential for flakiness here if ever a test from another file forgets to cleanup a rule that is in an error state or something along those lines.
|
@elasticmachine merge upstream |
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
ymao1
approved these changes
Jun 1, 2021
YulNaumenko
approved these changes
Jun 1, 2021
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @mikecote |
mikecote
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 2, 2021
* Initial commit * Expand tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #99930.
In this PR, I'm fixing the alerting health APIs to consider rules in all spaces instead of the default space only.