Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[packages] Move @kbn/interpreter to Bazel #101089
[packages] Move @kbn/interpreter to Bazel #101089
Changes from 1 commit
2d7663f
fd5b266
50a94ba
c84a520
559aee9
6a09dd1
ead7202
ba84fe6
2ff1c09
429984c
40d7093
6b922cf
ff2423c
25fb1da
efdea8e
d8906bd
2eba61e
5f94c44
38e516e
d67f320
851098b
d57f376
04b4927
d1209fe
f558973
4a69ae1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we run this as part of bootstrap ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbudz probably in order to accomplish this we need to do something like https://github.com/elastic/kibana/blob/master/packages/kbn-tinymath/BUILD.bazel#L33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
except that interpreter is not using peggy yet but still the old pegjs.
i am ok with moving to peggy in the same pr as long as it doesn't break
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.