Splits migrationsv2 actions and unit tests into separate files #101200
Conversation
TinaHeiligers
added
v8.0.0
release_note:skip
| @@ -19,7 +19,7 @@ async function removeLogFile() { | |||
| // ignore errors if it doesn't exist | |||
| await asyncUnlink(logFilePath).catch(() => void 0); | |||
| } | |||
|
|
|||
| // TINA TODO: figure out why this test is failing | |||
| * Side Public License, v 1. | ||
| */ | ||
|
|
||
| import { catchRetryableEsClientErrors } from './catch_retryable_es_client_errors'; |
There was a problem hiding this comment.
the current PR shows that we don't have good test coverage in the unit tests. we also have some integration tests for actions https://github.com/elastic/kibana/blob/5ff9382330d38763703fd05e308742495190c480/src/core/server/saved_objects/migrationsv2/integration_tests/actions.test.ts
Since we are not splitting the tests by action type (as this would significantly slow down their execution) should we at least move them closer to this /actions folder?
Makes sense. Not within the scope of the original issue but we could do it anyway. |
TinaHeiligers
added
the
auto-backport
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
…ic#101200) * Splits migrationsv2 actions and unit tests into separate files * Moves actions integration tests
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…) (#101304) * Splits migrationsv2 actions and unit tests into separate files * Moves actions integration tests Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
Summary
Resolves #99479
The migrations v2 implementation's actions are split into one file per action to improve navigating the code.
This PR specifically splits the
src/core/server/saved_objects/migrationsv2/actions/index.tsandsrc/core/server/saved_objects/migrationsv2/actions/index.test.tsfiles into one-per-action type.An additional file was created for the
CONSTANTSpreviously declared in index.ts.Checklist
For maintainers