Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stack Management] Converted to use KibanaPageTemplate (sort of) #101335

Merged
merged 13 commits into from
Jun 8, 2021
Merged

[Stack Management] Converted to use KibanaPageTemplate (sort of) #101335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1c9a81c
Just replace the old wrapper….
May 28, 2021
96e8fe3
Using `solutionNav` prop
May 28, 2021
8756fc4
Merge remote-tracking branch 'upstream/master' into pageLayouts/stack…
Jun 3, 2021
f24ac5d
Cleanup
Jun 3, 2021
bbb74b7
Example: Empty Page
Jun 3, 2021
56cf855
Example: Error state
Jun 3, 2021
ebc33a2
Example: Page Header
Jun 3, 2021
bc3b85b
Example: Split Panel
Jun 3, 2021
4fe6df6
i18n
Jun 3, 2021
71be6f1
Snaps
Jun 4, 2021
6983c35
Fix TS errors.
cjcenizal Jun 7, 2021
72c7d56
Fix functional tests.
cjcenizal Jun 7, 2021
133edba
Merge branch 'master' into pageLayouts/stack_management/setup
kibanamachine Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kbn-docs-utils/src/api_docs/tests/snapshots/plugin_a.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,7 +598,7 @@
"section": "def-public.ImAType",
"text": "ImAType"
},
", e?: string | undefined) => ",
", e: string | undefined) => ",
{
"pluginId": "pluginA",
"scope": "public",
Expand Down
6 changes: 6 additions & 0 deletions src/core/public/styles/_base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,9 @@
.euiBody--collapsibleNavIsDocked .euiBottomBar {
margin-left: $euiCollapsibleNavWidth;
}

// Temporary fix for EuiPageHeader with a bottom border but no tabs or padding
// Will fix in EUI -- @cchaos
.euiPageHeader--bottomBorder:not(.euiPageHeader--tabsAtBottom):not([class*='euiPageHeader--padding']) {
padding-bottom: $euiSizeL;
}
1 change: 1 addition & 0 deletions src/plugins/advanced_settings/public/management_app/advanced_settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@ export class AdvancedSettings extends Component<AdvancedSettingsProps, AdvancedS
dockLinks={this.props.dockLinks}
toasts={this.props.toasts}
trackUiMetric={this.props.trackUiMetric}
queryText={query.text}
/>
<PageFooter
toasts={this.props.toasts}
Expand Down
Loading