Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting: Task Manager integration for 7.x #101339

Merged
merged 13 commits into from
Jun 24, 2021

Conversation

tsullivan
Copy link
Member

@tsullivan tsullivan commented Jun 3, 2021

Summary

This PR removes ESQueue from Reporting and backports #64853 to the 7.x branch. Kibana stays compatible with pending reports that were scheduled with ESQueue in an earlier 7.x version by polling for report documents that do not have a kibanaVersion field.

Testing:

Queue up a bunch of reports while running the current 7.x. While some reports are still pending, switch the code to this PR branch, and restart Kibana. The pending reports should be "migrated" by being detected in the reports:monitor task and rescheduled as tasks with Task Manager.

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan tsullivan marked this pull request as ready for review June 23, 2021 19:15
@tsullivan tsullivan added backport v7.14.0 (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead labels Jun 23, 2021
@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
reporting 123 131 +8

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
reporting 17 18 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
reporting 85.4KB 85.5KB +24.0B
Unknown metric groups

API count

id before after diff
reporting 124 132 +8

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit 0f4e999 into elastic:7.x Jun 24, 2021
@tsullivan tsullivan deleted the reporting/tm-backport-7x branch June 24, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead v7.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants