Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Fix header row of data grid in Firefox #101374

Merged
merged 3 commits into from
Jun 7, 2021
Merged

[Discover] Fix header row of data grid in Firefox #101374

merged 3 commits into from
Jun 7, 2021

Conversation

dimaanj
Copy link
Contributor

@dimaanj dimaanj commented Jun 4, 2021 •
edited by kertal
Loading

Related to #101063

Summary

  • fixes header row in Firefox
  • have already backported into 7.x

8C56E89A-B8C4-41F3-A80F-EC6B0CBFB32C_4_5005_c

Checklist

@dimaanj dimaanj added Feature:Discover Discover Application release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.14.0 labels Jun 4, 2021
@dimaanj dimaanj requested a review from kertal June 4, 2021 12:10
@dimaanj dimaanj marked this pull request as ready for review June 4, 2021 14:35
@dimaanj dimaanj requested a review from a team as a code owner June 4, 2021 14:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@ryankeairns
Copy link
Contributor

Thanks for addressing this. Should the fix then be handled in EUI?

@kertal
Copy link
Member

kertal commented Jun 4, 2021

This is related to this issue in EUI, maybe it should be added or a new one should be created:

elastic/eui#4729?

kertal
kertal approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side, CSS should be removed once the issue is fixed in EUI

@ryankeairns ryankeairns mentioned this pull request Jun 4, 2021
Closed
ryankeairns
ryankeairns approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment which links to the EUI issue so we can find this more easily once that solution is in place. Thanks!

@dimaanj
Copy link
Contributor Author

dimaanj commented Jun 7, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fileUpload 128 - -128
licensing 44 - -44
savedObjectsTagging 50 - -50
security 36 - -36
securitySolution 32 - -32
telemetryCollectionXpack 1 - -1
timelines 6 - -6
total -297

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
fileUpload 4 - -4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 420.0KB 420.1KB +128.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
fileUpload 1 - -1
licensing 8 - -8
security 15 - -15
securitySolution 6 - -6
timelines 1 - -1
total -31
Unknown metric groups

API count

id before after diff
fileUpload 128 - -128
licensing 120 - -120
savedObjectsTagging 54 - -54
security 77 - -77
securitySolution 32 - -32
telemetryCollectionXpack 1 - -1
timelines 6 - -6
total -418

References to deprecated APIs

id before after diff
licensing 18 - -18
security 2 - -2
securitySolution 390 - -390
total -410

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dimaanj dimaanj merged commit d1c7e98 into elastic:master Jun 7, 2021
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 7, 2021
@gmmorris
Merge branch 'master' into task-manager/capacity-estimation
e40b071 
* master: (90 commits)
  Fix UI breaks on providing long search keyword in 'Search Box' (elastic#101385)
  Adds css class to EuiDescriptionListDescription in order to break word on exception details card (elastic#101481)
  [Lens] Increase timings for drag and drop tests (elastic#101380)
  [Lens] Fix editor react error on configuration panel (elastic#101367)
  [Fleet] Move integrations to a separate app (elastic#99848)
  Fix incorrect message displayed on importing Timeline Templates (elastic#101288)
  [Cases] RBAC (elastic#95058)
  [APM] Visual improvements for new APM layout with left navigation (elastic#101360)
  [master] More precise alerts matching (elastic#99820)
  [Lens] Value in legend (elastic#101353)
  Revert "[Reporting] ILM policy for managing reporting indices (elastic#100130)" (elastic#101358)
  [Discover] Fix header row of data grid in Firefox (elastic#101374)
  Add link to advanced setting in Discover (elastic#101154)
  Url service locators (elastic#101045)
  [Timelion] Update the removal message to mention the exact version (elastic#100994)
  [Security Solution][Detection Engine] Test cases for alias failure test cases where we don't copy aliases correctly (elastic#101437)
  [Event Log] Adding `type_id` to saved object array in event log (elastic#100939)
  [Reporting] Add `location.url` info to console message logs (elastic#101427)
  [Security Solutions][Detection Engine] Fixes timestamp bugs within source indexes when the formats are not ISO8601 format (elastic#101349)
  Improve Task Manager instrumentation (elastic#99160)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 9, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 101374 or prevent reminders by adding the backport:skip label.

@dimaanj dimaanj mentioned this pull request Jun 10, 2021
Merged
dimaanj added a commit to dimaanj/kibana that referenced this pull request Jun 10, 2021
@dimaanj
[Discover] Fix header row of data grid in Firefox (elastic#101374)
c34f104 
* [Discover] add fix of row header in firefox from previous version

* [Discover] add link comment to the issue

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/discover/public/application/components/discover_grid/discover_grid.scss
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 10, 2021
dimaanj added a commit that referenced this pull request Jun 10, 2021
@dimaanj
[Discover] Fix header row of data grid in Firefox (#101374) (#101879)
14eebdf 
* [Discover] add fix of row header in firefox from previous version

* [Discover] add link comment to the issue

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/discover/public/application/components/discover_grid/discover_grid.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankeairns ryankeairns ryankeairns approved these changes

@kertal kertal kertal approved these changes

Assignees
No one assigned
Labels
Feature:Discover Discover Application release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dimaanj @elasticmachine @ryankeairns @kertal @kibanamachine