Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visualize] Fixes functional tests to run for vislib and es-charts #101461

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jun 7, 2021

Summary

Fixes the visualize functional tests. Specifically, due to this change #98063, the functional tests that tested the es-charts implementation never run with the visualization:visualize:legacyChartsLibrary set to false. As a result, ci-group4 and ci-group7 were testing twice the vislib implementation.

I have changed this in order ci-group7 to run the tests for es-charts and ci-group4 to run the tests for vislib.

Checklist

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula marked this pull request as ready for review June 7, 2021 09:31
@stratoula stratoula added v7.14.0 v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jun 7, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula stratoula added the release_note:skip Skip the PR/issue when compiling release notes label Jun 7, 2021
@stratoula stratoula requested a review from LeeDr June 7, 2021 09:31
@stratoula stratoula added Feature:Functional Testing Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Jun 7, 2021
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - code review and checked Jenkins job

@stratoula stratoula merged commit 1cd88f4 into elastic:master Jun 7, 2021
stratoula added a commit that referenced this pull request Jun 8, 2021
…101461) (#101523)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Functional Testing Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants