Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability] [Cases] Cases in the observability app #101487

Merged
merged 160 commits into from
Jun 10, 2021
Merged

[Observability] [Cases] Cases in the observability app #101487

merged 160 commits into from
Jun 10, 2021

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Jun 7, 2021 •
edited
Loading

Summary

Cases in the observability app. Identical to this PR, but now against master since the feature branch was merged. Four new views:

1. All Cases

/observability/cases

1

2. Create Case

/observability/cases/create

2

3. Case Details

/observability/cases/:detailName

3

4. Configure Case

/observability/cases/configure

4

There is still a flag in kibana.dev.yml on Observability/Cases in the sidebar menu:
xpack.observability.unsafe.cases.enabled: true

Internal ticket: https://github.com/elastic/security-team/issues/853

It's working! Still to do:

  • fix missing breadcrumbs
  • connect userPermissions for each page
  • connect useFetchAlertData
  • connect showAlertDetails (in security we open timeline)
  • update values for ruleDetailsNavigation
  • No longer pursuing alerts in this PR. making the above mentioned properties optional in Cases UI wherever used: useFetchAlertData, showAlertDetails, ruleDetailsNavigation
  • test!

jonathan-buttner and others added 30 commits March 9, 2021 16:21
@jonathan-buttner
Adding feature flag for auth
7f1a7dd
@jonathan-buttner
Hiding SOs and adding consumer field
164582d
@jonathan-buttner
First pass at adding security changes
7eaf41e
@cnasikas
Consumer as the app's plugin ID
f8e62c6
@cnasikas
Create addConsumerToSO migration helper
09589c3
@cnasikas
Fix mapping's SO consumer
eb75eb0
@cnasikas
Add test for CasesActions
a930f03
@cnasikas
Declare hidden types on SO client
d6f3b09
@cnasikas
Restructure integration tests
b82e686
@cnasikas
Init spaces_only integration tests
4d05175
@jonathan-buttner
Implementing the cases security string
75d72ae
@jonathan-buttner
Merge branch 'master' of github.com:elastic/kibana into cases-rbac-poc
e65838b
@jonathan-buttner
Adding security plugin tests for cases
1fd66af
@jonathan-buttner
Rough concept for authorization class
4560d42
@jonathan-buttner
Adding comments
ef9b3b2
@cnasikas
Fix merge
b22a032
@cnasikas
Get requiredPrivileges for classes
ddc2280
@cnasikas
Check privillages
9d008d8
@cnasikas
Ensure that all classes are available
7bb23dd
@cnasikas
Success if hasAllRequested is true
65d4c6b
@cnasikas
Failure if hasAllRequested is false
59e4045
@jonathan-buttner
Adding schema updates for feature plugin
4092733
@cnasikas
Seperate basic from trial
311e3f4
@cnasikas
Enable SIR on integration tests
f2a50d3
@jonathan-buttner
Starting the plumbing for authorization in plugin
00d89ca
@cnasikas
Merge branch 'master' into cases-rbac-poc
40cfcce
@jonathan-buttner
Unit tests working
644a7ac
@jonathan-buttner
Merge branch 'cases-rbac-poc-plugin-changes' into cases-rbac-poc
9bb1b86
@cnasikas
Move find route logic to case client
12d6e2e
@cnasikas
Create integration test helper functions
84d9167
@stephmilovic stephmilovic requested a review from a team as a code owner June 9, 2021 16:19
@stephmilovic stephmilovic requested a review from a team as a code owner June 9, 2021 16:33
@stephmilovic stephmilovic requested a review from a team as a code owner June 9, 2021 16:35
legrego
legrego reviewed Jun 9, 2021
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests and additional edits! Just one comment left from me -- sorry this will end up touching a few files, but I hope it's not too invasive

x-pack/plugins/observability/server/plugin.ts Show resolved Hide resolved
legrego
legrego approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security changes LGTM - thanks!

jonathan-buttner
jonathan-buttner approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @stephmilovic !

TinaHeiligers
TinaHeiligers approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry changes LGTM!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cases 253 254 +1
observability 289 313 +24
total +25

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
cases 395 398 +3
observability 194 195 +1
total +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 503.4KB 505.2KB +1.8KB
observability 454.0KB 483.3KB +29.3KB
total +31.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 50.5KB 52.3KB +1.9KB
Unknown metric groups

API count

id before after diff
cases 431 434 +3
observability 194 195 +1
total +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic merged commit de07e98 into elastic:master Jun 10, 2021
@stephmilovic stephmilovic deleted the cases_obs branch June 10, 2021 22:39
@stephmilovic stephmilovic mentioned this pull request Jun 10, 2021
Merged
stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Jun 10, 2021
@stephmilovic
[Observability] [Cases] Cases in the observability app (elastic#101487)
9d7af06
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 14, 2021
@gmmorris
Merge branch 'master' into task-manager/capacity-estimation
4b96500 
* master: (68 commits)
  skip flaky suite (elastic#94043)
  skip flaky suite (elastic#102012)
  [esArchive] Persists updates for management/saved_objects/* (elastic#101992)
  skip flaky suite (elastic#101449)
  remove unnecessary hack (elastic#101909)
  [Exploratory View] Use human readable formats (elastic#101520)
  [Expressions] Refactor expression functions to use observables underneath (elastic#100409)
  [esArchives] Persist migrated Kibana archives (elastic#101950)
  [kbnArchiver] fix save to non-existent file (elastic#101974)
  [Enterprise Search] Add owner and description properties to kibana.json (elastic#101957)
  [DOCS] Fixes terminology in Stack Monitoring:Kibana alerts (elastic#101696)
  [Observability] [Cases] Cases in the observability app (elastic#101487)
  [Alerting][Docs] Combine rule creation and management pages (elastic#101498)
  temporarily disable build-buddy
  [Fleet] Fix fleet server collector in case settings are not set (elastic#101752)
  [Event Log] Populated rule.* ECS fields for alert events. (elastic#101132)
  [APM] Fleet support for merging input.config values with other nested properties in the policy input (elastic#101690)
  Add comments to some alerting plugin public API items (elastic#101551)
  [Alerting][Docs] Moving alerting setup to its own page (elastic#101323)
  remove uptime public API, it's not used. (elastic#101799)
  ...
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added backport missing Added to PRs automatically when the are determined to be missing a backport. and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jun 14, 2021
stephmilovic added a commit that referenced this pull request Jun 15, 2021
@stephmilovic @kibanamachine
[7.x] [Observability] [Cases] Cases in the observability app (#101487) (
3bba37f 
#101971)

* [Observability] [Cases] Cases in the observability app (#101487)

* Fix archive

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* fix data

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas left review comments

@michaelolo24 michaelolo24 michaelolo24 left review comments

@smith smith smith approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@legrego legrego legrego approved these changes

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

@jonathan-buttner jonathan-buttner jonathan-buttner approved these changes

Assignees
No one assigned
Labels
Feature:RAC label obsolete release_note:feature Makes this part of the condensed release notes Team:Observability Team label for Observability Team (for things that are handled across all of observability) Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team Theme: rac label obsolete v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@stephmilovic @elasticmachine @smith @kibanamachine @pgayvallet @legrego @cnasikas @TinaHeiligers @michaelolo24 @jonathan-buttner