-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[es-archiver] Use alias for Kibana mappings #101537
[es-archiver] Use alias for Kibana mappings #101537
Conversation
In 7.x, when saved objects point to an index and not an alias it will assume it's pre-6.8 and perform a legacy migration. This causes issues with the removal of oss builds. This update prevents that from happening by using an alias. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Jenkins, test it |
5a1455b
to
44c6dad
Compare
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Pinging @elastic/kibana-operations (Team:Operations) |
I guess if we create any new es_archives for Kibana we would need to manually change from the index to an alias? |
@LeeDr Saving an esArchive for a Kibana index will actually include the alias. I assume these ones were just really old. Soon we won't allow esArchives to manipulate the Kibana index. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maps changes lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad we figured this out!
LGTM
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
In 7.x, when saved objects point to an index and not an alias it will assume it's pre-6.8 and perform a legacy migration. This causes issues with the removal of oss builds. This update prevents that from happening by using an alias. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
In 7.x, when saved objects point to an index and not an alias it will assume it's pre-6.8 and perform a legacy migration. This causes issues with the removal of oss builds. This update prevents that from happening by using an alias. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
In 7.x, when saved objects point to an index and not an alias it will
assume it's pre-6.8 and perform a legacy migration. This causes issues
with the removal of oss builds. This update prevents that from happening
by using an alias.