Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[es-archiver] Use alias for Kibana mappings #101537

Merged

Conversation

tylersmalley
Copy link
Contributor

In 7.x, when saved objects point to an index and not an alias it will
assume it's pre-6.8 and perform a legacy migration. This causes issues
with the removal of oss builds. This update prevents that from happening
by using an alias.

In 7.x, when saved objects point to an index and not an alias it will
assume it's pre-6.8 and perform a legacy migration. This causes issues
with the removal of oss builds. This update prevents that from happening
by using an alias.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley
Copy link
Contributor Author

Jenkins, test it

@tylersmalley tylersmalley force-pushed the es-archives-kbn-alias-no-data branch from 5a1455b to 44c6dad Compare June 7, 2021 23:56
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley added v7.14.0 v8.0.0 Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes labels Jun 8, 2021
@tylersmalley tylersmalley marked this pull request as ready for review June 8, 2021 03:50
@tylersmalley tylersmalley requested review from a team as code owners June 8, 2021 03:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@LeeDr
Copy link

LeeDr commented Jun 8, 2021

I guess if we create any new es_archives for Kibana we would need to manually change from the index to an alias?
The only reason we would still try to use es_archive is for saved objects which don't support export/import.

@tylersmalley
Copy link
Contributor Author

tylersmalley commented Jun 8, 2021

@LeeDr Saving an esArchive for a Kibana index will actually include the alias. I assume these ones were just really old. Soon we won't allow esArchives to manipulate the Kibana index.

Copy link
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maps changes lgtm!

Copy link
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad we figured this out!
LGTM

@tylersmalley tylersmalley added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 8, 2021
@tylersmalley tylersmalley merged commit ec212c0 into elastic:master Jun 8, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 8, 2021
In 7.x, when saved objects point to an index and not an alias it will
assume it's pre-6.8 and perform a legacy migration. This causes issues
with the removal of oss builds. This update prevents that from happening
by using an alias.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley pushed a commit that referenced this pull request Jun 8, 2021
In 7.x, when saved objects point to an index and not an alias it will
assume it's pre-6.8 and perform a legacy migration. This causes issues
with the removal of oss builds. This update prevents that from happening
by using an alias.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants