Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Cases] Get connector's information from actionsTypeRegistry (#101279) #101570

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Jun 8, 2021

Backports the following commits to 7.x:

…ic#101279)

Co-authored-by: Yuliia Naumenko <yuliia.naumenko@elastic.com>
@cnasikas cnasikas enabled auto-merge (squash) June 8, 2021 10:39
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / general / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/exception_operators_data_types/ip·ts.detection engine api security and spaces enabled Detection exceptions data types and operators Rule exception operators for data type ip "is not in list" operator will return 2 results if we have a list that excludes 2 ips

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: detection engine api security and spaces enabled
[00:00:00]           └-> "before all" hook in "detection engine api security and spaces enabled"
[00:00:00]           └-: 
[00:00:00]             └-> "before all" hook in ""
[00:00:00]             └-: Detection exceptions data types and operators
[00:00:00]               └-> "before all" hook in "Detection exceptions data types and operators"
[00:00:00]               └-: 
[00:00:00]                 └-> "before all" hook in ""
[00:00:00]                 └-: Rule exception operators for data type ip
[00:00:00]                   └-> "before all" hook in "Rule exception operators for data type ip"
[00:05:42]                   └-: "is not in list" operator
[00:05:42]                     └-> "before all" hook for "will return 1 result if we have a list that excludes 1 ip"
[00:05:42]                     └-> will return 1 result if we have a list that excludes 1 ip
[00:05:42]                       └-> "before each" hook: global before each for "will return 1 result if we have a list that excludes 1 ip"
[00:05:42]                       └-> "before each" hook for "will return 1 result if we have a list that excludes 1 ip"
[00:05:42]                         │ info [o.e.x.i.a.TransportPutLifecycleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] adding index lifecycle policy [.siem-signals-default]
[00:05:42]                         │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] adding template [.siem-signals-default] for index patterns [.siem-signals-default-*]
[00:05:42]                         │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] [.siem-signals-default-000001] creating index, cause [api], templates [.siem-signals-default], shards [1]/[1]
[00:05:43]                         │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] moving index [.siem-signals-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.siem-signals-default]
[00:05:43]                         │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] moving index [.siem-signals-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [.siem-signals-default]
[00:05:43]                         │ info [o.e.x.i.a.TransportPutLifecycleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] adding index lifecycle policy [.lists-default]
[00:05:43]                         │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] moving index [.siem-signals-default-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [.siem-signals-default]
[00:05:43]                         │ info [o.e.x.i.a.TransportPutLifecycleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] adding index lifecycle policy [.items-default]
[00:05:43]                         │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] adding template [.lists-default] for index patterns [.lists-default-*]
[00:05:43]                         │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] adding template [.items-default] for index patterns [.items-default-*]
[00:05:43]                         │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] [.lists-default-000001] creating index, cause [api], templates [.lists-default], shards [1]/[1]
[00:05:43]                         │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] moving index [.lists-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.lists-default]
[00:05:43]                         │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] [.items-default-000001] creating index, cause [api], templates [.items-default], shards [1]/[1]
[00:05:43]                         │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] moving index [.lists-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [.lists-default]
[00:05:43]                         │ info [rule_exceptions/ip] Loading "mappings.json"
[00:05:43]                         │ info [rule_exceptions/ip] Loading "data.json"
[00:05:43]                         │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] [ip] creating index, cause [api], templates [], shards [1]/[1]
[00:05:43]                         │ info [rule_exceptions/ip] Created index "ip"
[00:05:43]                         │ debg [rule_exceptions/ip] "ip" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:05:43]                         │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] moving index [.items-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.items-default]
[00:05:43]                         │ info [rule_exceptions/ip] Indexed 4 docs into "ip"
[00:05:43]                         │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] moving index [.lists-default-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [.lists-default]
[00:05:43]                       │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] moving index [.items-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [.items-default]
[00:05:43]                       │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] moving index [.items-default-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [.items-default]
[00:05:54]                       │ proc [kibana]   log   [11:49:44.842] [info][plugins][securitySolution] [+] Finished indexing 1  signals searched between date ranges [
[00:05:54]                       │ proc [kibana]   {
[00:05:54]                       │ proc [kibana]     "to": "2021-06-08T11:49:43.831Z",
[00:05:54]                       │ proc [kibana]     "from": "1900-01-01T00:00:00.000Z",
[00:05:54]                       │ proc [kibana]     "maxSignals": 100
[00:05:54]                       │ proc [kibana]   }
[00:05:54]                       │ proc [kibana] ] name: "Signal Testing Query" id: "9975fc30-c84f-11eb-97bf-8167742d65c0" rule id: "rule-1" signals index: ".siem-signals-default"
[00:05:54]                       │ proc [kibana]   log   [11:49:44.848] [info][eventLog][plugins] event logged: {"@timestamp":"2021-06-08T11:49:41.841Z","event":{"provider":"alerting","action":"execute","start":"2021-06-08T11:49:41.841Z","outcome":"success","end":"2021-06-08T11:49:44.847Z","duration":3006000000},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"9975fc30-c84f-11eb-97bf-8167742d65c0","type_id":"siem.signals"}],"alerting":{"status":"ok"},"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"alert executed: siem.signals:9975fc30-c84f-11eb-97bf-8167742d65c0: 'Signal Testing Query'","ecs":{"version":"1.8.0"}}
[00:05:54]                       └- ✓ pass  (11.4s) "detection engine api security and spaces enabled  Detection exceptions data types and operators  Rule exception operators for data type ip "is not in list" operator will return 1 result if we have a list that excludes 1 ip"
[00:05:54]                     └-> "after each" hook for "will return 1 result if we have a list that excludes 1 ip"
[00:05:54]                       │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] [.siem-signals-default-000001/lBedpNBcT02KWG6GOaLw3Q] deleting index
[00:05:54]                       │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] removing template [.siem-signals-default]
[00:05:57]                       │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] [.lists-default-000001/oP3th7QPTBaSquImRFbL4g] deleting index
[00:05:57]                       │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] [.items-default-000001/w5y0joQ4SS20Oe1_Zs3vPw] deleting index
[00:05:57]                       │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] removing template [.lists-default]
[00:05:58]                       │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] removing template [.items-default]
[00:05:58]                       │ info [rule_exceptions/ip] Unloading indices from "mappings.json"
[00:05:58]                       │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] [ip/lVnUI9b_SU2e6hQOJh2lGQ] deleting index
[00:05:58]                       │ info [rule_exceptions/ip] Deleted existing index "ip"
[00:05:58]                       │ info [rule_exceptions/ip] Unloading indices from "data.json"
[00:05:58]                     └-> will return 2 results if we have a list that excludes 2 ips
[00:05:58]                       └-> "before each" hook: global before each for "will return 2 results if we have a list that excludes 2 ips"
[00:05:58]                       └-> "before each" hook for "will return 2 results if we have a list that excludes 2 ips"
[00:05:58]                         │ info [o.e.x.i.a.TransportPutLifecycleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] adding index lifecycle policy [.siem-signals-default]
[00:05:58]                         │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] adding template [.siem-signals-default] for index patterns [.siem-signals-default-*]
[00:05:58]                         │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] [.siem-signals-default-000001] creating index, cause [api], templates [.siem-signals-default], shards [1]/[1]
[00:05:58]                         │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] moving index [.siem-signals-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.siem-signals-default]
[00:05:58]                         │ info [o.e.x.i.a.TransportPutLifecycleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] adding index lifecycle policy [.lists-default]
[00:05:58]                         │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] moving index [.siem-signals-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [.siem-signals-default]
[00:05:58]                         │ info [o.e.x.i.a.TransportPutLifecycleAction] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] adding index lifecycle policy [.items-default]
[00:05:58]                         │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] moving index [.siem-signals-default-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [.siem-signals-default]
[00:05:58]                         │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] adding template [.lists-default] for index patterns [.lists-default-*]
[00:05:58]                         │ info [o.e.c.m.MetadataIndexTemplateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] adding template [.items-default] for index patterns [.items-default-*]
[00:05:58]                         │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] [.lists-default-000001] creating index, cause [api], templates [.lists-default], shards [1]/[1]
[00:05:58]                         │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] moving index [.lists-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.lists-default]
[00:05:58]                         │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] [.items-default-000001] creating index, cause [api], templates [.items-default], shards [1]/[1]
[00:05:58]                         │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] moving index [.lists-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [.lists-default]
[00:05:58]                         │ info [rule_exceptions/ip] Loading "mappings.json"
[00:05:58]                         │ info [rule_exceptions/ip] Loading "data.json"
[00:05:58]                         │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] [ip] creating index, cause [api], templates [], shards [1]/[1]
[00:05:58]                         │ info [rule_exceptions/ip] Created index "ip"
[00:05:58]                         │ debg [rule_exceptions/ip] "ip" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:05:58]                         │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] moving index [.items-default-000001] from [null] to [{"phase":"new","action":"complete","name":"complete"}] in policy [.items-default]
[00:05:58]                         │ info [rule_exceptions/ip] Indexed 4 docs into "ip"
[00:05:58]                         │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] moving index [.lists-default-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [.lists-default]
[00:05:58]                       │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] moving index [.items-default-000001] from [{"phase":"new","action":"complete","name":"complete"}] to [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] in policy [.items-default]
[00:05:58]                       │ info [o.e.x.i.IndexLifecycleTransition] [kibana-ci-immutable-ubuntu-18-tests-xxl-1623148826989734176] moving index [.items-default-000001] from [{"phase":"hot","action":"unfollow","name":"branch-check-unfollow-prerequisites"}] to [{"phase":"hot","action":"rollover","name":"check-rollover-ready"}] in policy [.items-default]
[00:06:06]                       │ proc [kibana]   log   [11:49:56.978] [info][eventLog][plugins] event logged: {"@timestamp":"2021-06-08T11:49:56.829Z","event":{"provider":"alerting","action":"execute","start":"2021-06-08T11:49:56.829Z","outcome":"failure","end":"2021-06-08T11:49:56.978Z","duration":149000000,"reason":"execute"},"kibana":{"saved_objects":[{"rel":"primary","type":"alert","id":"a27db110-c84f-11eb-97bf-8167742d65c0","type_id":"siem.signals"}],"alerting":{"status":"error"},"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"alert execution failure: siem.signals:a27db110-c84f-11eb-97bf-8167742d65c0: 'Signal Testing Query'","error":{"message":"[siem-detection-engine-rule-status:a5756d40-c84f-11eb-97bf-8167742d65c0]: version conflict, required seqNo [510], primary term [1]. current document has seqNo [511] and primary term [1]: version_conflict_engine_exception"},"ecs":{"version":"1.8.0"}}
[00:06:06]                       │ proc [kibana]   log   [11:49:56.984] [error][alerting][alerting][plugins][plugins] Executing Alert "a27db110-c84f-11eb-97bf-8167742d65c0" has resulted in Error: [siem-detection-engine-rule-status:a5756d40-c84f-11eb-97bf-8167742d65c0]: version conflict, required seqNo [510], primary term [1]. current document has seqNo [511] and primary term [1]: version_conflict_engine_exception, caused by: ""
[00:07:10]                       └- ✖ fail: detection engine api security and spaces enabled  Detection exceptions data types and operators  Rule exception operators for data type ip "is not in list" operator will return 2 results if we have a list that excludes 2 ips
[00:07:10]                       │      Error: timed out waiting for function condition to be true within waitForRuleSuccess
[00:07:10]                       │       at /dev/shm/workspace/parallel/5/kibana/x-pack/test/detection_engine_api_integration/utils.ts:743:9
[00:07:10]                       │ 
[00:07:10]                       │ 

Stack Trace

Error: timed out waiting for function condition to be true within waitForRuleSuccess
    at /dev/shm/workspace/parallel/5/kibana/x-pack/test/detection_engine_api_integration/utils.ts:743:9

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cases 255 254 -1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
triggersActionsUi 232 228 -4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 502.1KB 503.5KB +1.4KB
triggersActionsUi 1.7MB 1.7MB -9.0B
total +1.4KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
triggersActionsUi 29 19 -10

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 133.5KB 132.1KB -1.4KB
triggersActionsUi 73.8KB 71.3KB -2.4KB
total -3.8KB
Unknown metric groups

API count

id before after diff
triggersActionsUi 241 237 -4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cnasikas cnasikas merged commit 919eb94 into elastic:7.x Jun 8, 2021
@cnasikas cnasikas deleted the backport/7.x/pr-101279 branch June 8, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants