[APM] Add link-to/transaction route #101731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgieselaar
added
Team:APM
|
Pinging @elastic/apm-ui (Team:apm) |
sorenlouv
approved these changes
Jun 9, 2021
sorenlouv
reviewed
Jun 9, 2021
| { term: { [TRACE_ID]: traceId } }, | ||
| ...rangeQuery(start, end), | ||
| ...(traceId ? [{ term: { [TRACE_ID]: traceId } }] : []), | ||
| ...('start' in setup ? rangeQuery(setup.start, setup.end) : []), |
There was a problem hiding this comment.
Are setup.start and setup.end typed as optionals here? Would be great if they were but I seem to recall we require them on every api
There was a problem hiding this comment.
(or maybe it's the opposite problem I'm thinking about where they are always optional, even when they are required on the api)
There was a problem hiding this comment.
This function is used in different endpoints, one that does have a start/end query parameter, and one that doesn't. The type for setup here is a union type of setup without start/end (not defined) and setup with start end (always defined).
💚 Build SucceededMetrics [docs]Module Count
Async chunks
To update your PR or re-run it, just comment with: |
dgieselaar
added
the
auto-backport
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 9, 2021
kibanamachine
added a commit
that referenced
this pull request
Jun 9, 2021
smith
reviewed
Jun 9, 2021
| <CentralizedContainer> | ||
| <EuiEmptyPrompt | ||
| iconType="apmTrace" | ||
| title={<h2>Fetching transaction...</h2>} |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 9, 2021
* master: clarify which parts of TM are experimental (elastic#101757) Add sh scripts with _bulk_action route usage examples (elastic#101736) [Uptime] Only register route in side nav if uptime show capability is true (elastic#101709) Use KIBANA_DOCS in doc link service (elastic#101667) [Alerting][Event log] Persisting duration information for active alerts in event log (elastic#101387) Address design issues in Discover/Graph (elastic#101584) Optimize performance for document table (elastic#101715) Change file data visualizer links to point to new location in home application (elastic#101393) [Fleet] Tighten policy permissions, take II (elastic#97366) [ML] Add debounce to the severity control update (elastic#101581) [Fleet] Fix routing issues with `getPath` and `history.push` (elastic#101658) [APM] Add link-to/transaction route (elastic#101731) [Index Patterns] Runtime fields CRUD REST API (elastic#101164) [ILM] Refactor types and fix missing aria labels (elastic#101518) [Lens] New summary row feature for datatable (elastic#101075) Blocks save event filter with a white space name (elastic#101599) Improve security server types (elastic#101661) [APM] Replace side nav with tabs on Settings page (elastic#101460) [APM] Only register items in side nav if user has permissions to see app (elastic#101707) [Security solution][Endpoint] Add back button when to the event filters list (elastic#101280)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
/app/apm/link-to/transaction/:transactionIdroute, that will link to a transaction detail page for the transaction, instead of the root transaction of a trace.I've used this in demo's, for linking from a transaction in discover to the trace waterfall. Not sure if this is useful enough, but the maintenance costs seems low, so just putting it up for discussion.