Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Alerting][Docs] Combine rule creation and management pages (#101498) #101979

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Jun 11, 2021

Backports the following commits to 7.x:

…101498)

* Combining rule management stuff into single page

* Cleaning up image widths and header sizes

* Adding in placeholder pages

* Adding in placeholder pages

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* PR and test fixes

* Apply suggestions from code review

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

* PR fixes

* PR fixes

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	docs/user/monitoring/kibana-alerts.asciidoc
@ymao1 ymao1 added the backport label Jun 11, 2021
@ymao1 ymao1 enabled auto-merge (squash) June 11, 2021 00:14
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 410.6KB 410.7KB +7.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ymao1 ymao1 merged commit edad104 into elastic:7.x Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants