[Kuery] Move json utils #102058

lizozom · 2021-06-14T13:21:52Z

Summary

Move JsonArray, JsonValue and JsonObject back to the kbn-utils package (they were moved out of es-kuery in #51014).
This was done to allow more easily moving es-kuery back to packages

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

…-json-utils

elasticmachine · 2021-06-14T13:21:56Z

Pinging @elastic/uptime (Team:uptime)

elasticmachine · 2021-06-14T13:24:58Z

Pinging @elastic/kibana-app-services (Team:AppServices)

tylersmalley · 2021-06-14T13:26:50Z

packages/kbn-utils/yarn.lock

@@ -0,0 +1,4 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.


I believe this file can be removed.

It was automatically created when I re-built the package. You sure @tylersmalley ?

That's odd - how did you re-build the package? Looks like this one was migrated to Bazel which can be built with yarn kbn build-bazel

https://www.elastic.co/guide/en/kibana/master//monorepo-packages.html#_building_bazel_packages

flash1293

Kibana app changes LGTM

ymao1

Alerting changes LGTM!

shahzad31

Uptime changes LGTM !!

tylersmalley

Ops changes LGTM

lizozom · 2021-06-14T14:38:40Z

@elasticmachine merge upstream

lykkin

🎉

peteharverson

ML edit LGTM

jloleysens

Did not test locally, all changes look safe and happy if CI is passing 🍻

weltenwort

The infra plugin code changes look good to me. But I encountered the same problem as CI when running Kibana, so I couldn't test it in action.

…-json-utils

…into es-kuery/move-json-utils

kibanamachine · 2021-06-16T14:48:46Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`infra`	902	904	+2
`kibanaUtils`	192	191	-1
total			+1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`kibanaUtils`	373	365	-8

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
`kibanaUtils`	5	3	-2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`infra`	1.7MB	1.7MB	+618.0B
`kibanaUtils`	108.3KB	108.3KB	-1.0B
total			+617.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kibanaUtils`	138.4KB	136.9KB	-1.5KB

Unknown metric groups

API count

id	before	after	diff
`kibanaUtils`	551	543	-8

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lizozom

* Move JSON utils to utils package * Imports from tests * delete * split package * docs * test * test * imports Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-06-16T15:18:27Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

* Move JSON utils to utils package * Imports from tests * delete * split package * docs * test * test * imports Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Liza Katz <lizka.k@gmail.com>

Liza K added 3 commits June 14, 2021 15:20

Move JSON utils to utils package

148af16

Imports from tests

0b79d06

Merge branch 'master' of github.com:elastic/kibana into es-kuery/move…

e5f9f80

…-json-utils

lizozom requested review from a team as code owners June 14, 2021 13:21

lizozom requested a review from a team June 14, 2021 13:21

lizozom requested review from a team as code owners June 14, 2021 13:21

botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jun 14, 2021

lizozom self-assigned this Jun 14, 2021

lizozom added v7.14.0 v8.0.0 labels Jun 14, 2021

lizozom added release_note:skip Skip the PR/issue when compiling release notes Team:AppServices labels Jun 14, 2021

tylersmalley reviewed Jun 14, 2021

View reviewed changes

delete

83645da

flash1293 approved these changes Jun 14, 2021

View reviewed changes

sorenlouv approved these changes Jun 14, 2021

View reviewed changes

ymao1 approved these changes Jun 14, 2021

View reviewed changes

shahzad31 approved these changes Jun 14, 2021

View reviewed changes

tylersmalley approved these changes Jun 14, 2021

View reviewed changes

jbudz approved these changes Jun 14, 2021

View reviewed changes

Merge branch 'master' into es-kuery/move-json-utils

33f7a87

lykkin approved these changes Jun 14, 2021

View reviewed changes

peteharverson approved these changes Jun 14, 2021

View reviewed changes

jloleysens approved these changes Jun 15, 2021

View reviewed changes

weltenwort self-requested a review June 15, 2021 10:45

weltenwort approved these changes Jun 15, 2021

View reviewed changes

Liza K added 8 commits June 15, 2021 18:44

Merge branch 'master' of github.com:elastic/kibana into es-kuery/move…

6b51a9a

…-json-utils

split package

04206fb

Merge branch 'master' of github.com:elastic/kibana into es-kuery/move…

3f895f4

…-json-utils

Merge branch 'es-kuery/move-json-utils' of github.com:lizozom/kibana …

4248be7

…into es-kuery/move-json-utils

docs

b1ccf5c

test

e02bd98

test

9ab64da

imports

6347118

lizozom merged commit 8abb656 into elastic:master Jun 16, 2021

lizozom added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 16, 2021

kibanamachine mentioned this pull request Jun 16, 2021

[7.x] [Kuery] Move json utils (#102058) #102365

Merged

lizozom mentioned this pull request Jun 23, 2021

[Data - Query Service] Move es-query back into a dedicated package #51659

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Kuery] Move json utils #102058

[Kuery] Move json utils #102058

lizozom commented Jun 14, 2021 •

edited

Loading

elasticmachine commented Jun 14, 2021

elasticmachine commented Jun 14, 2021

tylersmalley Jun 14, 2021

lizozom Jun 14, 2021

lizozom Jun 14, 2021

tylersmalley Jun 14, 2021

flash1293 left a comment

ymao1 left a comment

shahzad31 left a comment

tylersmalley left a comment

lizozom commented Jun 14, 2021

lykkin left a comment

peteharverson left a comment

jloleysens left a comment

weltenwort left a comment

kibanamachine commented Jun 16, 2021

API count

kibanamachine commented Jun 16, 2021

		@@ -0,0 +1,4 @@
		# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.

[Kuery] Move json utils #102058

[Kuery] Move json utils #102058

Conversation

lizozom commented Jun 14, 2021 • edited Loading

Summary

Checklist

Risk Matrix

For maintainers

elasticmachine commented Jun 14, 2021

elasticmachine commented Jun 14, 2021

tylersmalley Jun 14, 2021

Choose a reason for hiding this comment

lizozom Jun 14, 2021

Choose a reason for hiding this comment

lizozom Jun 14, 2021

Choose a reason for hiding this comment

tylersmalley Jun 14, 2021

Choose a reason for hiding this comment

flash1293 left a comment

Choose a reason for hiding this comment

ymao1 left a comment

Choose a reason for hiding this comment

shahzad31 left a comment

Choose a reason for hiding this comment

tylersmalley left a comment

Choose a reason for hiding this comment

lizozom commented Jun 14, 2021

lykkin left a comment

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

jloleysens left a comment

Choose a reason for hiding this comment

weltenwort left a comment

Choose a reason for hiding this comment

kibanamachine commented Jun 16, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Any counts in public APIs

Async chunks

Page load bundle

API count

History

kibanamachine commented Jun 16, 2021

💚 Backport successful

lizozom commented Jun 14, 2021 •

edited

Loading