[master] Fix esArchiver path in the Jenkins workspace #102095
Conversation
cavokz
added
release_note:skip
cavokz
requested review from
spalger
and removed request for
LeeDr and
MadameSheema
cavokz
changed the title
cavokz
added
the
auto-backport
It was not obvious to me it would be needed but at least I learned something new of our CI also today. |
cavokz
changed the title
💔 Backport failedThe backport operation could not be completed due to the following error: The backport PRs will be merged automatically after passing CI. To backport manually run: |
cavokz
added
v7.14.0
auto-backport
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
There was a problem hiding this comment.
I'm a little confused by the diffs because the "old" versions look different than what I see in master? But I think loading the esArchives already work OK both locally and in Jenkins because of how we set the esArchive folder in the config file.
But to load data in the remote cluster you probably do want to set INTEGRATION_TEST_ROOT within the test file and use it in the path
| const ARCHIVE = resolve( | ||
| INTEGRATION_TEST_ROOT, | ||
| 'test/es_archives/email_connectors_with_encryption_rotation' | ||
| ); |
There was a problem hiding this comment.
Some of these existing tests shouldn't need this change because they're loading data into the local cluster and esArchive already works for that. This test gets the correct path because of the INTEGRATION_TEST_ROOT defined in the config file.
There was a problem hiding this comment.
There is no more esArchive path in the config.
| @@ -15,7 +20,7 @@ export default function ({ getService, getPageObjects, updateBaselines }) { | |||
|
|
|||
| describe('check metricbeat Dashboard', function () { | |||
| before(async function () { | |||
| await esArchiver.load('../integration-test/test/es_archives/metricbeat'); | |||
| await esArchiver.load(ARCHIVE); | |||
There was a problem hiding this comment.
I don't think we need any change here. The current version that just does await esArchiver.load('metricbeat'); should work both locally and in Jenkins.
There was a problem hiding this comment.
await esArchiver.load('metricbeat'); does not work any more after #101345, a path relative to kibana/ or an absolute path is now needed.
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Fix after #101345 and #101737.