Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Unload canvas test properly #102101

Merged
merged 3 commits into from
Jun 16, 2021
Merged

[Lens] Unload canvas test properly #102101

merged 3 commits into from
Jun 16, 2021

Conversation

flash1293
Copy link
Contributor

Fixes #101999
Fixes #102003

In CI, Canvas tests run in ci group 2 and Lens tests in ci group 4, so they can't interfere. But in cloud tests, Lens runs after canvas so Canvas adding a document to the logstash-lens index causes issues for the Lens tests to run.

This PR makes sure the index is properly unloaded after the test

@flash1293 flash1293 added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Lens v7.14.0 release_note:skip Skip the PR/issue when compiling release notes labels Jun 14, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review June 15, 2021 09:35
@flash1293 flash1293 requested a review from a team as a code owner June 15, 2021 09:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

wylieconlon
wylieconlon approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally by grepping for all lens tests, where Canvas runs first. LGTM

poffdeluxe
poffdeluxe approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@flash1293 flash1293 added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 16, 2021
@flash1293 flash1293 merged commit 036c157 into elastic:master Jun 16, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 16, 2021
@flash1293 @kibanamachine
[Lens] Unload canvas test properly (elastic#102101)
7b28c7b
@kibanamachine kibanamachine mentioned this pull request Jun 16, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 16, 2021
@kibanamachine @flash1293
[Lens] Unload canvas test properly (#102101) (#102350)
fcf1389 
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
This was referenced Aug 16, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poffdeluxe poffdeluxe poffdeluxe approved these changes

@wylieconlon wylieconlon wylieconlon approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@flash1293 @kibanamachine @elasticmachine @wylieconlon @poffdeluxe