[K8] Added `Inter` font files for new theme #102359

cchaos · 2021-06-16T14:56:46Z

... and Updated the Fonts file to accept a themeVersion and only use the old Beta files if v7.

The EUI Amsterdam theme ships using the newest version of the Inter font family which has changed it's name from Inter UI to just Inter. This adds these updated font files, uses the right paths/names depending on the current Kibana theme v7 or v8.

Before

After

Checklist

Unit or functional tests were updated or added to match the most common scenarios
This was checked for cross-browser compatibility

Updated the `Fonts` file to accept a `themeVersion` and only use the old Beta files if `v7`.

spalger

LGTM when running locally, looks like the visual testing stuff needs updated screenshots, which I'd harvest from the GCS Uploads once the build is complete.

cchaos · 2021-06-16T16:20:48Z

Thanks @spalger , that's the plan! 🤞

src/core/server/core_app/assets/fonts/readme.md

pgayvallet · 2021-06-16T18:43:24Z

src/core/server/rendering/types.ts

@@ -24,6 +24,7 @@ export interface RenderingMetadata {
  i18n: typeof i18n.translate;
  locale: string;
  darkMode: boolean;
+  themeVersion?: string;


Why optional?

Mainly because there's an import of the Font file that doesn't have access to the current theme version.

kibana/x-pack/plugins/security/server/prompt_page.tsx

Line 67 in ab2a80f

<Fonts url={uiPublicURL} />

Hum, yea. Ideally we'd want to adapt these two calls from security to retrieve the themeVersion setting, however it wouldn't do much, as these pages are rendered when security is enabled and user not authenticated, meaning that it would default to v8 anyway, so I guess having it optional and performing the default/fallback in core's component probably makes sense.

src/core/server/rendering/views/fonts.tsx

spalger · 2021-06-16T20:22:20Z

jenkins, test this

(restarting due to jenkins upgrade)

cchaos · 2021-06-16T22:44:37Z

jenkins, test this

I don't really understand why this one keeps timing out or how it would be related to this PR, so trying again for the night.

1 failing
     │
     │1)    discover app
     │       discover doc table
     │         legacy
     │           should make the document table scrollable:
     │
     │      timed out waiting for container to be scrollable -- last error: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="field-geo.coordinates"])
     │ Wait timed out after 10014ms

spalger · 2021-06-16T23:58:15Z

Hmm, looks like that field is there in the screenshot 🤔

marius-dr

LGTM

kertal · 2021-06-17T14:12:53Z

@spalger it should not need to add it, because it's waiting for scrollWidth > clientWidth

[00:20:26] │ debg scrollWidth: 938, clientWidth: 938
[00:20:26] │ debg TestSubjects.moveMouseTo(field-agent)
[00:20:26] │ debg TestSubjects.find(field-agent)
[00:20:26] │ debg Find.findByCssSelector('[data-test-subj="field-agent"]') with timeout=10000
[00:20:27] │ debg TestSubjects.click(fieldToggle-agent)
[00:20:27] │ debg Find.clickByCssSelector('[data-test-subj="fieldToggle-agent"]') with timeout=10000
[00:20:27] │ debg Find.findByCssSelector('[data-test-subj="fieldToggle-agent"]') with timeout=10000
[00:20:30] │ debg scrollWidth: 1020, clientWidth: 938
[00:20:30] │ debg TestSubjects.moveMouseTo(field-bytes)
[00:20:30] │ debg TestSubjects.find(field-bytes)
[00:20:30] │ debg Find.findByCssSelector('[data-test-subj="field-bytes"]') with timeout=10000
[00:20:31] │ debg TestSubjects.click(fieldToggle-bytes)
[00:20:31] │ debg Find.clickByCssSelector('[data-test-subj="fieldToggle-bytes"]') with timeout=10000
[00:20:31] │ debg Find.findByCssSelector('[data-test-subj="fieldToggle-bytes"]') with timeout=10000
[00:20:34] │ debg scrollWidth: 1118, clientWidth: 938

ist should be fine when the agent file is being added, but it just continues?

kertal · 2021-06-17T14:40:49Z

@spalger it should not need to add it, because it's waiting for scrollWidth > clientWidth

Ok, I think I know what could work, scrollWidth: 1020, clientWidth: 938 in the test are not converted to numbers

'1020' > '938' = false

kibana/test/functional/apps/discover/_doc_table.ts

Line 239 in 97feae3

return scrollWidth > clientWidth;

so it should be

return Number(scrollWidth) > Number(clientWidth);

Then the check should work, seems this PR changed the widths of the columns

spalger · 2021-06-17T17:29:54Z

Looks like @kertal was right, but got snagged by a flaky "unit" test

cchaos · 2021-06-17T17:31:36Z

I was wondering if that one for sure is flakey. But I'll update from master anyway and get a new CI going.

@elasticmachine merge upstream

cchaos · 2021-06-17T17:33:08Z

@elasticmachine merge upstream

kibanamachine · 2021-06-17T19:40:21Z

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kertal · 2021-06-17T20:06:20Z

🥳

Updated the `Fonts` file to accept a `themeVersion` and only use the old Beta files if `v7`. # Conflicts: # test/functional/screenshots/baseline/tsvb_dashboard.png # test/interpreter_functional/screenshots/baseline/metric_multi_metric_data.png

…ets-tab * 'master' of github.com:elastic/kibana: (93 commits) [ML] Remove blank job definition as it is unused and out-of-sync with Elasticsearch (elastic#102506) [Lens] Fix wrong error detection on transition to Top values operation (elastic#102384) [ML] Anomaly detection job custom_settings improvements (elastic#102099) [Cases] Route: Get all alerts attach to a case (elastic#101878) Fixes wrong list exception type when creating endpoint event filters list (elastic#102522) remove search bar that's not working yet (elastic#102550) Migrated Ingest Node Pipeline Functional Tests to use test_user (elastic#102409) [Maps] clean up feature editing name space to avoid conflicts with layer settings editing (elastic#102516) [canvas] Refactor Storybook from bespoke to standard configuration (elastic#101962) [Security Solution] adds wrapSequences method (RAC) (elastic#102106) [FTR] Stabilize SSLP functional tests (elastic#102553) [K8] Added `Inter` font files for new theme (elastic#102359) [Workplace Search] Convert Groups pages to new page template (elastic#102449) [DOC] Add experimental disclaimer to rollup jobs (elastic#95624) [Security Solution][Endpoint] Suppress some of the jest console.error noise created by endpoint list middelware (elastic#102535) [Fleet] Improve performance of Fleet setup (elastic#102219) [Alerting] Add event log entry when a rule starts executing (elastic#102001) [Fleet] Update docker image of registry used in integration tests (elastic#101911) [Asset Management] Osquery telemetry updates (elastic#100754) Converts saved object tagging to new management layout (elastic#102284) ... # Conflicts: # x-pack/plugins/fleet/kibana.json

* [K8] Added `Inter` font files for new theme (#102359) Updated the `Fonts` file to accept a `themeVersion` and only use the old Beta files if `v7`. # Conflicts: # test/functional/screenshots/baseline/tsvb_dashboard.png # test/interpreter_functional/screenshots/baseline/metric_multi_metric_data.png * Update baseline snapshot Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

[K8] Added Inter font files for new theme

87cbe9e

Updated the `Fonts` file to accept a `themeVersion` and only use the old Beta files if `v7`.

cchaos requested review from spalger and marius-dr June 16, 2021 14:56

cchaos requested a review from a team as a code owner June 16, 2021 14:56

cchaos added v7.14.0 release_note:skip Skip the PR/issue when compiling release notes labels Jun 16, 2021

spalger reviewed Jun 16, 2021

View reviewed changes

pgayvallet reviewed Jun 16, 2021

View reviewed changes

cchaos added 2 commits June 16, 2021 15:24

Update some screenshots

3e10e72

Moving to functions

91ea2e1

cchaos requested a review from pgayvallet June 16, 2021 19:45

pgayvallet approved these changes Jun 17, 2021

View reviewed changes

marius-dr approved these changes Jun 17, 2021

View reviewed changes

Attempting fix at doc_table test

9a112bf

Merge branch 'master' into k8_fix/font-family

5719eef

cchaos merged commit e483351 into elastic:master Jun 17, 2021

cchaos mentioned this pull request Jun 17, 2021

[7.x] [K8] Added Inter font files for new theme (#102359) #102579

Merged

cchaos deleted the k8_fix/font-family branch March 11, 2022 17:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[K8] Added `Inter` font files for new theme #102359

[K8] Added `Inter` font files for new theme #102359

cchaos commented Jun 16, 2021 •

edited

Loading

spalger left a comment

cchaos commented Jun 16, 2021

pgayvallet Jun 16, 2021

cchaos Jun 16, 2021

pgayvallet Jun 17, 2021

spalger commented Jun 16, 2021

cchaos commented Jun 16, 2021

spalger commented Jun 16, 2021

marius-dr left a comment

kertal commented Jun 17, 2021

kertal commented Jun 17, 2021 •

edited

Loading

spalger commented Jun 17, 2021

cchaos commented Jun 17, 2021

cchaos commented Jun 17, 2021

kibanamachine commented Jun 17, 2021

kertal commented Jun 17, 2021

[K8] Added Inter font files for new theme #102359

[K8] Added Inter font files for new theme #102359

Conversation

cchaos commented Jun 16, 2021 • edited Loading

Checklist

spalger left a comment

Choose a reason for hiding this comment

cchaos commented Jun 16, 2021

pgayvallet Jun 16, 2021

Choose a reason for hiding this comment

cchaos Jun 16, 2021

Choose a reason for hiding this comment

pgayvallet Jun 17, 2021

Choose a reason for hiding this comment

spalger commented Jun 16, 2021

cchaos commented Jun 16, 2021

spalger commented Jun 16, 2021

marius-dr left a comment

Choose a reason for hiding this comment

kertal commented Jun 17, 2021

kertal commented Jun 17, 2021 • edited Loading

spalger commented Jun 17, 2021

cchaos commented Jun 17, 2021

cchaos commented Jun 17, 2021

kibanamachine commented Jun 17, 2021

💚 Build Succeeded

Metrics [docs]

History

kertal commented Jun 17, 2021

[K8] Added `Inter` font files for new theme #102359

[K8] Added `Inter` font files for new theme #102359

cchaos commented Jun 16, 2021 •

edited

Loading

kertal commented Jun 17, 2021 •

edited

Loading