Update format_number time test for APJ timezones #102691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matschaffer
added
v8.0.0
release_note:skip
In EMEA timezones H:mm:ss can return 20:42:17
ruflin
approved these changes
Jun 22, 2021
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
matschaffer
added
v7.14.0
auto-backport
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @matschaffer |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 30, 2021
* Update format_number test for APJ timezones * Switch asertion to optional leading 1 * Allow leading 1 or 2 In EMEA timezones H:mm:ss can return 20:42:17 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jun 30, 2021
* Update format_number test for APJ timezones * Switch asertion to optional leading 1 * Allow leading 1 or 2 In EMEA timezones H:mm:ss can return 20:42:17 Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Mat Schaffer <mat@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the formatNumber time test for APJ timezones.
The test formats
1461868937000asH:mm:ssand expects a double digit return. Here in UTC+9, this formats as'3:42:17'which fails the assertion, so swapped the double digit for an optional leading1or2check.Checklist
For maintainers