Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locator docs #103129

Merged
merged 15 commits into from
Jun 28, 2021
Merged

Locator docs #103129

merged 15 commits into from
Jun 28, 2021

Conversation

streamich
Copy link
Contributor

@streamich streamich commented Jun 23, 2021 •
edited
Loading

Summary

Documentation for share plugin locators.

Closes #98108

@streamich streamich mentioned this pull request Jun 23, 2021
Closed
13 tasks
@streamich streamich marked this pull request as ready for review June 28, 2021 08:53
@streamich streamich requested a review from a team June 28, 2021 08:53
@streamich streamich requested review from a team as code owners June 28, 2021 08:53
@streamich
Copy link
Contributor Author

@elasticmachine merge upstream

ppisljar
ppisljar approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yuliacech
yuliacech approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack Management changes LGTM

kertal
kertal approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code owner review, just Discover mocks modified. didn't test

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit 82e32fa into elastic:master Jun 28, 2021
@streamich streamich mentioned this pull request Jun 28, 2021
Merged
streamich added a commit that referenced this pull request Jun 28, 2021
@streamich
Locator docs (#103129) (#103551)
8d1c01d 
* feat: 🎸 add locator_examples plugin

* feat: 🎸 add example app in locator_examples

* feat: 🎸 add locator_explorer plugin

* chore: 🤖 remove url_generaotrs_* example plugins

* docs: ✏️ update share plugin readme

* docs: ✏️ add locators readme

* docs: ✏️ update docs link in example plugin

* docs: ✏️ update navigation docs

* fix: 🐛 make P extend SerializableState

* test: 💍 update test mocks

* fix: 🐛 use correct type in ingest pipeline locator

* test: 💍 add missing methods in mock

* test: 💍 update test mocks

* chore: 🤖 update plugin list

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	examples/locator_examples/kibana.json
@KOTungseth KOTungseth added the Feature:SharingURLs Short URLs and Share URL features label Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

@yuliacech yuliacech yuliacech approved these changes

@kertal kertal kertal approved these changes

Assignees
No one assigned
Labels
Feature:SharingURLs Short URLs and Share URL features release_note:enhancement review v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL locator docs
7 participants
@streamich @elasticmachine @kibanamachine @kertal @yuliacech @ppisljar @KOTungseth