-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ILM] Update API integration test #103495
[ILM] Update API integration test #103495
Conversation
(policy) => policy.name === DEFAULT_POLICY_NAME | ||
); | ||
|
||
expect(version).to.eql(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seemed like we were doing a lot of work to delete or modify parts of the policy that were difficult to test. I think in_use_by
would also fall into that category. I decided to modify the test to only verify the options we know the expected values - version
, policy
and name
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for doing this, it will make the test future proof!
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for fixing this test, @alisonelizabeth! Changes LGTM 🚀
We are currently still working on the final design to add 'linked data' to ILM in data retention project so that users can easily find it in the UI. We are planning to display index templates and possibly data streams, but indices probably not.
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
Fixes #103364
The ES team recently added a new field called
in_use_by
to the GET ILM policy API that caused our API integration tests to fail. Related PR: elastic/elasticsearch#74518.Note: This only addresses the failed test. There's possibly other work needed to support this new field in the ILM UI. @yuliacech, thoughts?