Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ILM] Update API integration test #103495

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

alisonelizabeth
Copy link
Contributor

Fixes #103364

The ES team recently added a new field called in_use_by to the GET ILM policy API that caused our API integration tests to fail. Related PR: elastic/elasticsearch#74518.

Note: This only addresses the failed test. There's possibly other work needed to support this new field in the ILM UI. @yuliacech, thoughts?

@alisonelizabeth alisonelizabeth added chore Feature:ILM v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes failed-es-promotion v7.14.0 labels Jun 28, 2021
(policy) => policy.name === DEFAULT_POLICY_NAME
);

expect(version).to.eql(1);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seemed like we were doing a lot of work to delete or modify parts of the policy that were difficult to test. I think in_use_by would also fall into that category. I decided to modify the test to only verify the options we know the expected values - version, policy and name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this, it will make the test future proof!

@alisonelizabeth alisonelizabeth marked this pull request as ready for review June 28, 2021 15:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this test, @alisonelizabeth! Changes LGTM 🚀
We are currently still working on the final design to add 'linked data' to ILM in data retention project so that users can easily find it in the UI. We are planning to display index templates and possibly data streams, but indices probably not.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore failed-es-promotion Feature:ILM release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.14.0 v8.0.0
Projects
None yet
4 participants