Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [Alerting] Enable rule import/export and allow rule types to exclude themselves from export (#102999) #103598

Merged
merged 1 commit into from
Jun 29, 2021
Merged

[7.x] [Alerting] Enable rule import/export and allow rule types to exclude themselves from export (#102999) #103598

merged 1 commit into from
Jun 29, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

@ymao1 @kibanamachine
[Alerting] Enable rule import/export and allow rule types to exclude …
8d61a35 
…themselves from export (elastic#102999)

* Removing feature flag changes

* Adding isExportable flag to rule type definition

* Adding isExportable flag to rule type definition

* Adding isExportable flag to rule type definition

* Filtering rule on export by rule type isExportable flag

* Fixing types

* Adding docs

* Fix condition when exportCount is 0

* Unit test for fix condition when exportCount is 0

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine enabled auto-merge (squash) June 29, 2021 00:37
@kibanamachine kibanamachine mentioned this pull request Jun 29, 2021
Merged
2 tasks
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
alerting 206 208 +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 38.4KB 38.4KB +64.0B
Unknown metric groups

API count

id before after diff
alerting 214 216 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

@kibanamachine kibanamachine merged commit 0fd977a into elastic:7.x Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ymao1 ymao1

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kibanamachine @ymao1