Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove <7.14 EP Metrics from Security Solution usage collector #103632

Merged
merged 3 commits into from
Jun 29, 2021
Merged

Remove <7.14 EP Metrics from Security Solution usage collector #103632

merged 3 commits into from
Jun 29, 2021

Conversation

pjhampton
Copy link
Contributor

Summary

This PR removes EP metrics from the usage collector that will no longer work from 7.14 onwards due to a change on the EP.
Future EP metrics and diagnostics will be reconciled through a dedicated telemetry next channel.

See: #102171

@pjhampton pjhampton added Feature:Telemetry v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 29, 2021
@pjhampton pjhampton self-assigned this Jun 29, 2021
@pjhampton pjhampton requested a review from a team as a code owner June 29, 2021 10:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@pjhampton pjhampton requested review from a team as code owners June 29, 2021 10:29
@pjhampton pjhampton requested a review from Bamieh June 29, 2021 10:32
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pjhampton

michaelolo24
michaelolo24 approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@pjhampton pjhampton merged commit 096ee92 into master Jun 29, 2021
@kibanamachine kibanamachine mentioned this pull request Jun 29, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 29, 2021
@pjhampton @kibanamachine
Remove <7.14 EP Metrics from Security Solution usage collector (elast…
fdf24c5 
…ic#103632)

* Remove <7.14 EP Metrics from Security Solution usage collector.

* Update telemetry schema.

* Fix reworked method signature.
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@pjhampton pjhampton deleted the pjhampton/remove-ep-metrics-from-usage-collector branch June 29, 2021 15:59
kibanamachine added a commit that referenced this pull request Jun 29, 2021
@kibanamachine @pjhampton
Remove <7.14 EP Metrics from Security Solution usage collector (#103632…
bb01df8 
…) (#103702)

* Remove <7.14 EP Metrics from Security Solution usage collector.

* Update telemetry schema.

* Fix reworked method signature.

Co-authored-by: Pete Hampton <pjhampton@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

@Bamieh Bamieh Bamieh approved these changes

Assignees

@pjhampton pjhampton

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pjhampton @elasticmachine @kibanamachine @Bamieh @michaelolo24