Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Search UI access for Editor role #103951

Closed

Conversation

JasonStoltz
Copy link
Member

Summary

This PR disables access for Editors to the Search UI page in Kibana only.

The Search UI page now requires the ability to view credentials because it posts a Search API Key to ent-search to generate a preview.

Editors do not have this access. For that reason Search UI does NOT work for that role in the Kibana Plugin.

Because Editors should still have access to this page in ent-search, I did not want to remove access for that role entirely; I only want to remove access in Kibana.

For this reason, I chose to change the Search UI permission check to check both that the role has the Manage Search UI permission AND the View Credentials permission.

All other roles should remain unaffected.

Here is a screenshot comparing 7.14 ent-search and kibana, note that Editors still have access in ent-search but not in Kibana:

no-search-ui

Checklist

For maintainers

@JasonStoltz JasonStoltz requested a review from a team June 30, 2021 17:32
@JasonStoltz JasonStoltz added v7.14.0 v7.15.0 auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes and removed v7.15.0 labels Jun 30, 2021
@spalger spalger added v7.15.0 and removed v7.14.0 labels Jun 30, 2021
@JasonStoltz
Copy link
Member Author

Hey @spalger , I'd like this to backport to 7.14 also. SO I'd need 7.15 and 7.14 no?

@spalger
Copy link
Contributor

spalger commented Jun 30, 2021

@JasonStoltz sounds good, just doing general maintenance to all PRs open targeting 7.14 without targeting 7.15 to make sure that PRs aren't accidentally backported to 7.14 without being backported to the 7.x branch. You and your reviewers ultimately make the call about where it goes 👍

@JasonStoltz
Copy link
Member Author

Makes sense, thanks! 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.1MB 2.1MB +158.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@JasonStoltz JasonStoltz closed this Jul 1, 2021
@JasonStoltz JasonStoltz deleted the remove-search-ui-for-editor branch July 1, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants