Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Remove subseconds from event.ingested #104044

Merged

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Jul 1, 2021

Summary

The event.ingested field is added to all documents ingested via Fleet plus Agent.
By removing the subseconds we can be better compression of the values in
Elasticsearch. event.ingested will look like this 2021-06-30T12:06:28Z.

The primary user of event.ingested today is the the Security Detection Engine
as a tie-breaker in search_after, but once it moves to the using the
point-in-time API the need for precision will be lessened because PIT has
an implicit tie-breaker.

Relates #103944
Relates elastic/beats#22388

Checklist

For maintainers

@andrewkroh andrewkroh added Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team v7.15.0 auto-backport Deprecated - use backport:version if exact versions are needed v8.0.0 labels Jul 1, 2021
The `event.ingested` field is added to all documents ingested via
Fleet plus Agent. By removing the subseconds we can be better compression
of the values in Elasticsearch.

The primary user of `event.ingested` today is the the Security Detection Engine
as a tie-breaker in search_after, but once it moves to the using the
point-in-time API the need for precision will be lessened because PIT has
an implicit tie-breaker.

Relates elastic#103944
Relates elastic/beats#22388
@andrewkroh andrewkroh force-pushed the feature-evt-ingested-no-sub-sec branch from 722be0d to d72151e Compare July 1, 2021 17:32
@andrewkroh andrewkroh marked this pull request as ready for review July 1, 2021 22:10
@andrewkroh andrewkroh requested a review from a team as a code owner July 1, 2021 22:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Feature:Fleet)

@nchaulet
Copy link
Member

nchaulet commented Jul 6, 2021

@andrewkroh Do we want this in 7.14 too?

@nchaulet
Copy link
Member

nchaulet commented Jul 6, 2021

@elasticmachine merge upstream

@andrewkroh
Copy link
Member Author

@nchaulet I was targeting 7.15 in order to give time for #103944 to be implemented since this change could affect the queries used by the Security Detection engine.

@nchaulet
Copy link
Member

nchaulet commented Jul 7, 2021

@nchaulet I was targeting 7.15 in order to give time for #103944 to be implemented since this change could affect the queries used by the Security Detection engine.

👍 We will have to implement some migration mechanism to have this working in 7.15

@andrewkroh
Copy link
Member Author

We will have to implement some migration mechanism to have this working in 7.15

Migration with respect to what? Installing the upgraded pipeline?

@nchaulet
Copy link
Member

nchaulet commented Jul 8, 2021

Migration with respect to what? Installing the upgraded pipeline?

Yes, right now we do not install it again if it's already present

@jen-huang
Copy link
Contributor

@nchaulet Can you create an issue about migrating to new versions of the pipeline and add it to the iteration board for 7.15?

@andrewkroh
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 3, 2021
The `event.ingested` field is added to all documents ingested via
Fleet plus Agent. By removing the subseconds we can be better compression
of the values in Elasticsearch.

The primary user of `event.ingested` today is the the Security Detection Engine
as a tie-breaker in search_after, but once it moves to the using the
point-in-time API the need for precision will be lessened because PIT has
an implicit tie-breaker.

Relates elastic#103944
Relates elastic/beats#22388

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Aug 3, 2021
The `event.ingested` field is added to all documents ingested via
Fleet plus Agent. By removing the subseconds we can be better compression
of the values in Elasticsearch.

The primary user of `event.ingested` today is the the Security Detection Engine
as a tie-breaker in search_after, but once it moves to the using the
point-in-time API the need for precision will be lessened because PIT has
an implicit tie-breaker.

Relates #103944
Relates elastic/beats#22388

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
The `event.ingested` field is added to all documents ingested via
Fleet plus Agent. By removing the subseconds we can be better compression
of the values in Elasticsearch.

The primary user of `event.ingested` today is the the Security Detection Engine
as a tie-breaker in search_after, but once it moves to the using the
point-in-time API the need for precision will be lessened because PIT has
an implicit tie-breaker.

Relates elastic#103944
Relates elastic/beats#22388

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Fleet Fleet team's agent central management project release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants