-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] Add deprecation notice to the upgrade assistant #104303
[Reporting] Add deprecation notice to the upgrade assistant #104303
Conversation
Pinging @elastic/kibana-app-services (Team:AppServices) |
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This policy is automatically created in a newly set up environment, right? I'm wondering what is the best way to test this for reviewers. Can you add a writeup of how to test this PR?
I'm not sure if it would help, but perhaps it is handy to use our es_archive called reporting/archived_reports
. The index created from this archive does not come with the new built-in policy. However, there are only archived reports belonging to test_user
.
> node scripts/es_archiver.js \
--config x-pack/test/functional/config.js \
load x-pack/test/functional/es_archives/reporting/archived_reports \
--es-ca config/cert-bundle/ca/ca.crt \ # (use this example if you run Elasticsearch over HTTPS)
--es-url https://elastic:changeme@localhost:9200 \ # (change to http if needed)
--kibana-url http://elastic:changeme@localhost:5601 # (change to http if needed)
Edit: edited my thoughts
@elasticmachine merge upstream |
Great points @tsullivan ! I'll update the PR description with that information. The way I was testing this locally is by running the following request against the cluster: curl --request PUT \
--url 'http://localhost:9200/.reporting-*/_settings' \
--header 'Authorization: Basic ZWxhc3RpYzpjaGFuZ2VtZQ==' \
--header 'Content-Type: application/json' \
--data '{
"settings": {
"index.lifecycle.name": null
}
}' We also have API integration tests for creating a situation where reporting indices are "unmanaged":
Granted, this does not test all possible permutations of reporting indices out there (maybe some are already set up to be managed by an index template), but it does simulate the "default" state you would end up in (no index lifecycle policy set on reporting indices). |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…104303) * add deprecation notice to the upgrade assistant * fix types and update jest snapshot Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…#106537) * add deprecation notice to the upgrade assistant * fix types and update jest snapshot Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
Summary
Continuation of #100130 and fix #81544
This contribution adds an integration with the deprecation service. The deprecation flags the new reporting policy and provides a "quick resolution" in the upgrade assistant which uses the new "PUT /deprecations" endpoint.
How to test
Screenshots
Please note: the current Upgrade Assistant UI is subject to a lot of change prior to 8.0.
Checklist
Delete any items that are not applicable to this PR.