Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Refactoring menu section #104338

Merged
merged 1 commit into from
Jul 5, 2021
Merged

[APM] Refactoring menu section #104338

merged 1 commit into from
Jul 5, 2021

Conversation

cauemarcondes
Copy link
Contributor

Removing duplicate code from menu sections.

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 5, 2021
@cauemarcondes cauemarcondes requested a review from a team as a code owner July 5, 2021 17:25
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jul 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes cauemarcondes mentioned this pull request Jul 5, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1563 1564 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB -232.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sorenlouv
sorenlouv approved these changes Jul 5, 2021
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cauemarcondes cauemarcondes merged commit f5e7b46 into elastic:master Jul 5, 2021
@cauemarcondes cauemarcondes deleted the apm-refactoring-menu-sections branch July 5, 2021 21:15
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 5, 2021
@cauemarcondes @kibanamachine
[APM] Refactoring menu section (elastic#104338)
1c11c31
@kibanamachine kibanamachine mentioned this pull request Jul 5, 2021
Merged
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
❌ 7.14 Commit could not be cherrypicked due to conflicts
✅ 7.x

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 104338

cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Jul 5, 2021
@cauemarcondes
[APM] Refactoring menu section (elastic#104338)
38288bd 
# Conflicts:
#	x-pack/plugins/apm/public/components/shared/TransactionActionMenu/sections_helper.test.ts
#	x-pack/plugins/apm/public/components/shared/TransactionActionMenu/sections_helper.ts
@cauemarcondes cauemarcondes mentioned this pull request Jul 5, 2021
Merged
kibanamachine added a commit that referenced this pull request Jul 5, 2021
@kibanamachine @cauemarcondes
[APM] Refactoring menu section (#104338) (#104358)
639918e 
Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
cauemarcondes added a commit that referenced this pull request Jul 6, 2021
@cauemarcondes
[7.14] [APM] Refactoring menu section (#104338) (#104359)
bda4770 
* [APM] Refactoring menu section (#104338)

# Conflicts:
#	x-pack/plugins/apm/public/components/shared/TransactionActionMenu/sections_helper.test.ts
#	x-pack/plugins/apm/public/components/shared/TransactionActionMenu/sections_helper.ts

* adjusting path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.14.0 v7.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cauemarcondes @elasticmachine @kibanamachine @sorenlouv