Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] First accessibility test #104410

Merged
merged 6 commits into from
Jul 9, 2021

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Jul 6, 2021

Summary

This contribution adds a basic accessibility test for the reporting management UI with at least one report present.

Instructions referenced for set up: https://www.elastic.co/guide/en/kibana/master/development-tests.html#development-accessibility-tests

@jloleysens jloleysens added v8.0.0 Team:AppServices release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 6, 2021
@jloleysens jloleysens requested a review from dokmic July 6, 2021 11:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
reporting 70.4KB 70.4KB +84.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@dokmic dokmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jloleysens jloleysens merged commit 3e118c4 into elastic:master Jul 9, 2021
@jloleysens jloleysens deleted the reporting/add-a11y-tests branch July 9, 2021 13:04
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 9, 2021
* makeAllReportingPoliciesUnmanaged -> makeAllReportingIndicesUnmanaged

* expose the reporting services on the functional services object shared with a11y

* added data-test-subjs for a11y test

* added reporting a11y test

* updated jest test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 9, 2021
* makeAllReportingPoliciesUnmanaged -> makeAllReportingIndicesUnmanaged

* expose the reporting services on the functional services object shared with a11y

* added data-test-subjs for a11y test

* added reporting a11y test

* updated jest test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
@sophiec20 sophiec20 added the (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants