Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix Single Metric Viewer & Explorer annotation table actions overflow and annotations count not matching #104955

Merged
merged 5 commits into from
Jul 9, 2021
Merged

[ML] Fix Single Metric Viewer & Explorer annotation table actions overflow and annotations count not matching #104955

merged 5 commits into from
Jul 9, 2021

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Jul 8, 2021 •
edited
Loading

Summary

This PR fixes a regression introduced by #101236 which causes the labels to overlap in the Explorer/Single Metric View. The disabled option was also still clickable, which leads to an unsupported page.

Before
Screen Shot 2021-07-07 at 16 57 48

After

Annotations table in the Explorer view
Screen Shot 2021-07-08 at 11 42 12

Annotations table in the job list
Screen Shot 2021-07-08 at 13 00 38

When Single Metric Viewer view is disabled
Screen Shot 2021-07-08 at 11 41 39

Also fixes #98074 by indicating more clearly that we are only showing 500 annotations.

Screen Shot 2021-07-09 at 09 47 02

Checklist

Delete any items that are not applicable to this PR.

@qn895 qn895 added bug Fixes for quality problems that affect the customer experience :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.15.0 labels Jul 8, 2021
@qn895 qn895 requested a review from a team as a code owner July 8, 2021 18:11
@qn895 qn895 self-assigned this Jul 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@spalger
Copy link
Contributor

spalger commented Jul 8, 2021

jenkins, test this

(had to abort for Jenkins upgrade)

peteharverson
peteharverson approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@qn895 qn895 changed the title [ML] Fix Single Metric Viewer & Explorer annotation table display crowded actions [ML] Fix Single Metric Viewer & Explorer annotation table actions overflow, annotations count not matching Jul 9, 2021
@qn895 qn895 changed the title [ML] Fix Single Metric Viewer & Explorer annotation table actions overflow, annotations count not matching [ML] Fix Single Metric Viewer & Explorer annotation table actions overflow and annotations count not matching Jul 9, 2021
peteharverson
peteharverson approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest edits LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.9MB 5.9MB +269.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

alvarezmelissa87
alvarezmelissa87 approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@qn895 qn895 added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 9, 2021
@qn895 qn895 merged commit f7b87a5 into elastic:master Jul 9, 2021
@kibanamachine kibanamachine mentioned this pull request Jul 9, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 9, 2021
@qn895 @kibanamachine
[ML] Fix Single Metric Viewer & Explorer annotation table actions ove…
191a7a6 
…rflow and annotations count not matching (elastic#104955)

* Fix annotations

* Fix translations

* Fix onclick open

* Fix label/aggregations mismatch

* Fix title
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 9, 2021
@qn895 @kibanamachine
[ML] Fix Single Metric Viewer & Explorer annotation table actions ove…
b3323cd 
…rflow and annotations count not matching (elastic#104955)

* Fix annotations

* Fix translations

* Fix onclick open

* Fix label/aggregations mismatch

* Fix title
@kibanamachine kibanamachine mentioned this pull request Jul 9, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 9, 2021
@kibanamachine @qn895
[ML] Fix Single Metric Viewer & Explorer annotation table actions ove…
6dff3d0 
…rflow and annotations count not matching (#104955) (#105140)

* Fix annotations

* Fix translations

* Fix onclick open

* Fix label/aggregations mismatch

* Fix title

Co-authored-by: Quynh Nguyen <43350163+qn895@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Jul 9, 2021
@kibanamachine @qn895
[ML] Fix Single Metric Viewer & Explorer annotation table actions ove…
0ee0221 
…rflow and annotations count not matching (#104955) (#105141)

* Fix annotations

* Fix translations

* Fix onclick open

* Fix label/aggregations mismatch

* Fix title

Co-authored-by: Quynh Nguyen <43350163+qn895@users.noreply.github.com>
@qn895 qn895 deleted the ml-fix-annotations-actions branch July 21, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

Assignees

@qn895 qn895

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Annotations counts do not add up if there are more than 500
6 participants
@qn895 @elasticmachine @spalger @kibanamachine @alvarezmelissa87 @peteharverson