Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Add more Lens QA doc #105057

Merged
merged 5 commits into from
Jul 16, 2021
Merged

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Jul 9, 2021

Summary

More on #81780

Expanded the missing field answer based on previous PR, and added new question about datatable text styling.

Not sure about releasing with 7.14. You think it's ok @KOTungseth ?

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@@ -319,7 +319,12 @@ You can also change the index pattern for a single *Layer*.
[[why-my-field-x-is-missing-from-the-fields-list]]
===== Why is my field X missing from the fields list?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this just Why is my field missing from the list of fields?

When I read field X, I think x-axis.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see X as generic term, but I see what you mean. Will remove it.

docs/user/dashboard/lens.asciidoc Outdated Show resolved Hide resolved
docs/user/dashboard/lens.asciidoc Outdated Show resolved Hide resolved
*Lens* does not support the visualization of full-text fields, therefore it is not showing them in the data summary.
If your field is not in the `Available fields` list in *Lens* there may be multiple reasons, here described:
* the field is a full-text field, therefore it is not showing in the data summary.
* the field is a Geo field, therefore it is not showing in the data summary prior to v.7.14.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is best practice to avoid calling out versions in the docs because it is hard to maintain. If there are version-specific docs, we only push PRs to those specific versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is about why fields do not appear in the Available fields list, so I'm not sure we need to include information about data summaries.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Geo field correct? I'm not familiar with Maps, but is this the terminology they use?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

geo_point field is the naming in the app:

Screenshot 2021-07-14 at 14 43 39

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is about why fields do not appear in the Available fields list, so I'm not sure we need to include information about data summaries.

You are right. Prior to 7.14 is wasn't showing up in the Available fields, not data summaries

If your field is not in the `Available fields` list in *Lens* there may be multiple reasons, here described:
* the field is a full-text field, therefore it is not showing in the data summary.
* the field is a Geo field, therefore it is not showing in the data summary prior to v.7.14.0
* the mapping is not supported by index-patterns, for instance for fields in `flattened` objects
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data analysts are unfamiliar with the concept of mapping. This statement is more for admins.

I would reword this statement so that it applies to analysts, or remove it.

docs/user/dashboard/lens.asciidoc Outdated Show resolved Hide resolved
docs/user/dashboard/lens.asciidoc Outdated Show resolved Hide resolved
docs/user/dashboard/lens.asciidoc Outdated Show resolved Hide resolved
dej611 and others added 2 commits July 14, 2021 15:01
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dej611 dej611 merged commit 8e5d83d into elastic:master Jul 16, 2021
@dej611 dej611 deleted the lens/more-no-fields-doc branch July 16, 2021 08:55
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 16, 2021
* 📝 Add more Lens qa doc

* 🐛 Fix wrong ref

* 🔥 Remove section anchor for now

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

* 👌 Integrated feedback

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 16, 2021
* 📝 Add more Lens qa doc

* 🐛 Fix wrong ref

* 🔥 Remove section anchor for now

* Apply suggestions from code review

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

* 👌 Integrated feedback

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants