Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] Clean up types for internal APIs needed for UI #105508

Merged
merged 13 commits into from
Jul 15, 2021
Merged

[Reporting] Clean up types for internal APIs needed for UI #105508

merged 13 commits into from
Jul 15, 2021

Commits on Jul 13, 2021

  1. [Reporting] Refactor types for API response data

    @tsullivan
    tsullivan committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    3a85a26 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. Merge branch 'master' into reporting/job-apis-refactoring

    @tsullivan
    tsullivan committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    325767d View commit details
    Browse the repository at this point in the history

  2. fix api test

    @tsullivan
    tsullivan committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    abe2627 View commit details
    Browse the repository at this point in the history

  3. Update x-pack/plugins/reporting/common/types.ts 

    Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
    @tsullivan @jloleysens
    tsullivan and jloleysens authored Jul 14, 2021
    Configuration menu
    Copy the full SHA
    25b5017 View commit details
    Browse the repository at this point in the history

  4. more verbose comments

    @tsullivan
    tsullivan committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    50d8b98 View commit details
    Browse the repository at this point in the history

  5. set comments in interface type definition

    @tsullivan
    tsullivan committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    5cf4e22 View commit details
    Browse the repository at this point in the history

  6. Update x-pack/plugins/reporting/common/types.ts 

    Co-authored-by: Michael Dokolin <dokmic@gmail.com>
    @tsullivan @dokmic
    tsullivan and dokmic authored Jul 14, 2021
    Configuration menu
    Copy the full SHA
    b12d800 View commit details
    Browse the repository at this point in the history

  7. more strict

    @tsullivan
    tsullivan committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    5265dc9 View commit details
    Browse the repository at this point in the history

  8. Update x-pack/plugins/reporting/public/management/report_info_button.tsx 

    Co-authored-by: Michael Dokolin <dokmic@gmail.com>
    @tsullivan @dokmic
    tsullivan and dokmic authored Jul 14, 2021
    Configuration menu
    Copy the full SHA
    7d1b2a5 View commit details
    Browse the repository at this point in the history

  9. Update x-pack/plugins/reporting/public/management/report_info_button.tsx 

    Co-authored-by: Michael Dokolin <dokmic@gmail.com>
    @tsullivan @dokmic
    tsullivan and dokmic authored Jul 14, 2021
    Configuration menu
    Copy the full SHA
    6ad12c4 View commit details
    Browse the repository at this point in the history

  10. fix suggestion

    @tsullivan
    tsullivan committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    296e137 View commit details
    Browse the repository at this point in the history

  11. fix accidental declaration of interface methods as function properties

    @tsullivan
    tsullivan committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    93dadad View commit details
    Browse the repository at this point in the history

  12. fix info panel

    @tsullivan
    tsullivan committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    6c847d6 View commit details
    Browse the repository at this point in the history