Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fix pie chart with 0 decimal places for percent #105672

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

wylieconlon
Copy link
Contributor

@wylieconlon wylieconlon commented Jul 14, 2021

Fixes #104207

The fix is to allow 0 as a valid debounced value. I can't come up with a way to test this fix because the debug data for pie charts only contains the input values, not the formatted output, so this appears to be manually tested only.

I did unskip the functional tests for pie chart since I thought it would help me in my testing, but that's included in this PR as a bonus test that isn't actually related to the core change.

Steps to verify:

  1. Open a pie chart
  2. Open the text icon and choose 0 for the percent formatter
  3. The pie slices should display whole percents, not decimal

@wylieconlon wylieconlon added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 Feature:Lens auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 7.14.0 labels Jul 14, 2021
@wylieconlon wylieconlon requested a review from a team July 14, 2021 20:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +17.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, this works fine. I tested it locally for all partition charts. It works as expected

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.14
7.x

The backport PRs will be merged automatically after passing CI.

@wylieconlon wylieconlon deleted the lens/fix-pie-percent branch July 15, 2021 15:32
kibanamachine added a commit that referenced this pull request Jul 15, 2021
…5786)

Co-authored-by: Wylie Conlon <william.conlon@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 15, 2021
…5787)

Co-authored-by: Wylie Conlon <william.conlon@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Can't set 0 decimal places on pie/donut/treemap chart types
4 participants