-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.x] Fixes cypress flake across two tests (#105645) #105700
Closed
FrankHassanabad
wants to merge
7
commits into
elastic:7.x
from
FrankHassanabad:backport/7.x/pr-105645
Closed
[7.x] Fixes cypress flake across two tests (#105645) #105700
FrankHassanabad
wants to merge
7
commits into
elastic:7.x
from
FrankHassanabad:backport/7.x/pr-105645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary * Fixes flake where it looks like pre-built rules can take longer than 1 minute to load, so I increased that to 5 minutes * There are problems with how the `cy.intercept` is not always working on CI we don't understand yet, so I am removing the failing call but keeping the rest of the test for the failure. Backporting these two into `7.14` to add stability to `7.14` tests as well. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@elasticmachine merge upstream |
MadameSheema
approved these changes
Jul 15, 2021
…ibana into backport/7.x/pr-105645
This was referenced Jul 15, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Root cause was found and merged from here (we don't need this cleanup one anymore): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: